From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B7E5A9E72B7; Tue, 6 Feb 2024 16:27:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7E5A9E72B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707226068; bh=AFiQAzCJoY3vKHZNngKCCyzMP2AFV14Q2f6PqN9HinY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yIUR1oKy8GTn5wq9iAnacoOdWcoVGqjY5TDg7FhCOIh5091aFB81qTmJO9XZQNbNc ETKvb2OMVb2O3OXA3TG1wtu/OS2RBJO7D5kSWVZ2YvKzMOEPa6DPpBDrxMbV5xUreK 72B1E4/HjhybkerBoEoweT1hFu9MD/TdZSZDj+tY= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B37079E72B4 for ; Tue, 6 Feb 2024 16:27:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B37079E72B4 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1rXLUI-00000007M3Y-3KQR; Tue, 06 Feb 2024 16:27:47 +0300 Date: Tue, 6 Feb 2024 16:23:49 +0300 To: Maxim Kokryashkin Message-ID: References: <6279ec45b1a87b07f14827da242e82aed866e250.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DE389E818B66C7AEF74583E9BFD0023CE34868C9E9FB1C391867C24CE74E72BB5FE18E9CBFBE7C07A40BF571C211EA5A0E6CAD3CCF74BB25029D9EC61D84905AA59FCABF401CA7A551CE0648C9E8651D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637575C0790A70C4B158638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F636CE7AA1B91777D40D0BCCEE0F458FE490ACB7D4E173E2CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD181150BA43C84913FC3A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D1BA3128A69B615D5002B1117B3ED6969110E3319433B167BFF4097FFC9E796F823CB91A9FED034534781492E4B8EEAD253F27DA5A70FAF3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF2CA6144BE8221290063E645AC796B5F606EB64682CD32971FC0CAFDE074B130901EE030787A60D78807D692F32DC7032E26C18139CEBEB6D554DF534A1F5145E030B84BEE8E47D7D5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnOEaGGfMlimcA== X-DA7885C5: 54B5ECE4B0F8D3CEF255D290C0D534F9A527D8BCD466B29C9EE5FFADD1BBE0D703914951C69E96665B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE335D43B6EAAB4D454C8FBC218B1D33933CCC1AF53C4DCB7BD1E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/26] test: enable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the revew. Fixed your comment see the iterative patch below. On 31.01.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit below. > > On Mon, Jan 29, 2024 at 01:45:11PM +0300, Sergey Kaplun wrote: > > This patch declares functions as local to avoid pollution of the global > > environment. It separates the body of the test in the `do` `while` block > > and includes the test in . > > > > Part of tarantool/tarantool#9398 > > --- > > .../lib/ffi/ffi_gcstep_recursive.lua | 27 ++++++++++--------- > > test/LuaJIT-tests/lib/ffi/index | 1 + > > 2 files changed, 15 insertions(+), 13 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > > index cb19df11..f6e0b009 100644 > > --- a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > > +++ b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua > > @@ -1,6 +1,6 @@ > > -- From Robert G. Jakabosky, 2012-03-20 > > > > -local N=tonumber(arg[1] or 10000) > > +local N= 10000 > Something wrong with formatting here. Fixed. =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua index f6e0b009..3029defd 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_gcstep_recursive.lua @@ -1,6 +1,6 @@ -- From Robert G. Jakabosky, 2012-03-20 -local N= 10000 +local N = 10000 local ffi=require"ffi" =================================================================== > > -- Best regards, Sergey Kaplun