From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47B1E9E5CDA; Tue, 6 Feb 2024 15:14:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47B1E9E5CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707221656; bh=5hf3Fjyyh4F+yKtgtViCViqhRLgkUvbkac+Y1yuGIaU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eb8z38TRe1RhXr+jAOp84VmF9EgdbbSkOya3rdD6IkbTRiWv8LsWraoe7TDJ6Gqvn CZeHrhEGL7OT+6O/R+OPU1MYqF+VI8qMOfjTbK/B3n9ch1kUb6jdOaUbsjOJi534YE EdgE55/y9QyRvFfX8/8gfc4L4OhAaDyfZ5R7vAEo= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B650C9E5CDA for ; Tue, 6 Feb 2024 15:14:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B650C9E5CDA Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1rXKL8-000000077yO-1f7w; Tue, 06 Feb 2024 15:14:14 +0300 Date: Tue, 6 Feb 2024 15:10:17 +0300 To: Sergey Bronnikov Message-ID: References: <6cda5e07-00a9-440d-a6e1-0044dda8f889@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cda5e07-00a9-440d-a6e1-0044dda8f889@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD94C460F083DF69F515295F69A3DCCED9A65A8B27103DC31E2182A05F5380850400C1D9B275BDA77F091417EB218679B82E0F2DAB81490F480CA1D9A8F3B14CC980BFFC594198189FC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CA870F47FB69F4AC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D897778FBE742D520F65BF529BF1415A6CD833F2D08D39147FCC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD181150BA43C84913FC3A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A507773FA635E505215002B1117B3ED696BF4C017CED63989C30E4A65F242F5898823CB91A9FED034534781492E4B8EEADA333A05395E4745BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C02783DDD5A45DEFDA51B1E7B648DF337AF4DDFF1BFBAE4AB6B5C23C87EA8D3A7A8ED98317AF9C5B1D7E09C32AA3244CCC38E3110A5A89D50091A80DA37A96F32B2ABAEF4E78B429EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnOK7l6IECj5vg== X-DA7885C5: E368FF0FD65BA4A2F255D290C0D534F9C6B2E8B5179C18AE6AE4802B60D680D9613383206615DD035B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33628F39797A57BDADDA9803AAD7702155D87698D8123C90ACE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 01.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with a minor comment below > > On 1/29/24 13:45, Sergey Kaplun wrote: > > This patch changes the `dofile()` (which uses an unreliable relative > > file path and mutates `_G` with global functions to be defined) to the > > corresponding `require()`. Also, it names the only one test as "misc" > extra whitespace before "Also" Fixed, thanks! > > and includes the test in . > > > > Part of tarantool/tarantool#9398 > > --- The new commit message is the following: | test: enable in LuaJIT-tests | | This patch changes the `dofile()` (which uses an unreliable relative | file path and mutates `_G` with global functions to be defined) to the | corresponding `require()`. Also, it splits the test case into several | and includes the test in . | | Part of tarantool/tarantool#9398 -- Best regards, Sergey Kaplun