From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E884E9E5CC1; Tue, 6 Feb 2024 15:05:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E884E9E5CC1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707221107; bh=IJpJTf1GMIE6KeQsEXp2z2cw8ImzWn3oW7uvIxyW+9Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XHHYn9bVDCdf9MdcZ1O/1myvBUg6jHsQaHD8hlLtO+ibG8f/aj7bxLskBCS4m4GIb QAojdhLsY/3lxHagt9PhBZk6XKFbxZG6blAQ2Mp/whQky2K5E19xf9wffH2VB80kwb qqH5SKw8nUTPhUO3H9MteK66nzhAZjtpX57TCd88= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [95.163.41.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FFBF9E5CC1 for ; Tue, 6 Feb 2024 15:05:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FFBF9E5CC1 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1rXKCE-00000009Nhw-1uK7; Tue, 06 Feb 2024 15:05:03 +0300 Date: Tue, 6 Feb 2024 15:01:05 +0300 To: Sergey Bronnikov Message-ID: References: <620839b2-26a8-446d-83d8-e053c4cc61e6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <620839b2-26a8-446d-83d8-e053c4cc61e6@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51696B3613FE7F7BC4ACE7C5A96F709F6D182A05F538085040A8FB659CD5DD80105D1BE6A8D71B10A5D8C5018B5005D7E3CA1D9A8F3B14CC987B9585C59A2DDEF7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375CC217B55A7C05578638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81DE4E4F408F544F44FFA6763CD7E7C3BC34FC05504C14B97CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD181150BA43C84913FC3A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A55F6EC82C12F3A6755002B1117B3ED69670A28B7AD0316ADBC66B2B37046EC955823CB91A9FED034534781492E4B8EEAD253F27DA5A70FAF3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340A59E724FC7897F7B9C46DE69A2C19D1FD31DF59681596895875B2EA4EC11BC9001FC36E4DCA4B121D7E09C32AA3244C47F79F93EE8F7BA6E70D6F05539DA95A22D66A9C656591CDEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnM20DuYAg0hFw== X-DA7885C5: 1662BD5A4E1F57F2F255D290C0D534F9226B376F080E3F0E758549AF5E698684AE96D51CB4DCEB615B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3346162B51CBC8A4DBCA5C0191F8C84E147EF167E9CB908CB0E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment. On 01.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with minor comment below > > On 1/29/24 13:45, Sergey Kaplun wrote: > > This patch removes unused `dofile()`. Also, it uses the basename of the > > ctest library to be loaded via ffi. It adds groups with names of > > subtests and enables the test in . Complex type is undefined on > > Windows, so the correponding tests are not enabled for this platform. > > Fastcalls are enabled only for the x86 architecture. Stdcalls are > > enabled only for Windows on x86. Tests with calls with 10 arguments with > > sizes less than 8 bits are dummy for M1. This suite lacks a mechanism to > > too much "with" for my taste :) feel free to ignore Replaced the first "with" with:) containing. See the new commit message below: | test: enable in LuaJIT-tests | | This patch removes unused `dofile()`. Also, it uses the basename of the | ctest library to be loaded via ffi. It adds groups with names of | subtests and enables the test in . Complex type is undefined on | Windows, so the correponding tests are not enabled for this platform. | Fastcalls are enabled only for the x86 architecture. Stdcalls are | enabled only for Windows on x86. Tests containing calls with 10 | arguments with sizes less than 8 bits are dummy for M1. This suite lacks | a mechanism to skip subtests satisfying complicated conditions, so it is | done manually by the corresponding `if` check. | | Part of tarantool/tarantool#9398 > > Thanks for reformatting testcases, much more readable now. It's a pleasure :). -- Best regards, Sergey Kaplun