From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 536EE9E35EB; Tue, 6 Feb 2024 14:51:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 536EE9E35EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707220310; bh=d0OWS1Y4XFxmIaNY0YI0Eh4FEFcq4sMj4B4wODPGgYQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uM+aYu6sGRjrEwLIIfGxRnKlLnCw8k5uvLMtynEXN7RPBSKmdSUrIm9aPVwkxPRGS 0ViEkCDAnyJxIKfb3Qb63I8490JbfieqxH9k1bt6dtTKqR/BNgXfwazeMsM4rJYb39 u25Koh52B4t12YlOHJtiOgnQ1WAlcrjS3phcPWBc= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3295E9E35C2 for ; Tue, 6 Feb 2024 14:51:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3295E9E35C2 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1rXJzP-000000081zH-3BFX; Tue, 06 Feb 2024 14:51:48 +0300 Date: Tue, 6 Feb 2024 14:47:50 +0300 To: Maxim Kokryashkin Message-ID: References: <98fb92f07dcd2879a423006642f2bdcd4acfd9f2.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DE389E818B66C7AE631C3FCB5F86392615F258C2698FF6161867C24CE74E72BB5FE18E9CBFBE7C079FF04A4B38C21AE174445AC53D64B999F0FB1118185D6CD4A53BAF8E821FBC11660823B2EEFD31DC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063736901D4B68B3D4FF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CA48767145093E807E1E19FFF9B55BB9C9B46ADDD06E1E63CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC2EE5AD8F952D28FBE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A569A053A02BA0A0565002B1117B3ED696BD9EDDCC76E52EA5886DC9BC01168B20823CB91A9FED034534781492E4B8EEADA333A05395E4745BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF12726EC4182C82EFCBF2908805755393C001525913A4714AC434E38E5F22FBADF62474FBACD619B0807D692F32DC70328650805108B2EE53870F8584213AA4BE3233FC664D33CD375F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMEnksCPA0N/A== X-DA7885C5: 099AC1962B51B963F255D290C0D534F9996B62C005A29E31578DB32AB1DDB9E05972611C1FCC50765B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE335F5115809D978066A0FE85AAA2A9BA20872F0A79E36A4AEEE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 03/26] test: separate LuaJIT helpers from ffi_util.inc X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments, see the iterative patch below. On 31.01.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits below. > > On Mon, Jan 29, 2024 at 01:45:03PM +0300, Sergey Kaplun wrote: > > This patch moves common helpers from > > --- /dev/null > > +++ b/test/LuaJIT-tests/common/ffi/checktypes.lua > > @@ -0,0 +1,15 @@ > > +local ffi = require("ffi") > > + > > +-- Checker that takes an array with the following each 3 elements: > Typo: s/each 3 elements/triplets/ Fixed thanks! > > +-- 1) Sizeof for the given C type to be checked. > > +-- 2) Alignof for the given C type to be checked. > Nit: `sizeof()` and `alignof()` or something like that? Feel free to > ignore. Renamed. =================================================================== diff --git a/test/LuaJIT-tests/common/ffi/checktypes.lua b/test/LuaJIT-tests/common/ffi/checktypes.lua index c995d667..b5e04480 100644 --- a/test/LuaJIT-tests/common/ffi/checktypes.lua +++ b/test/LuaJIT-tests/common/ffi/checktypes.lua @@ -1,8 +1,8 @@ local ffi = require("ffi") --- Checker that takes an array with the following each 3 elements: --- 1) Sizeof for the given C type to be checked. --- 2) Alignof for the given C type to be checked. +-- Checker that takes an array with the following triplets: +-- 1) `sizeof()` for the given C type to be checked. +-- 2) `alignof()` for the given C type to be checked. -- 3) String representing the C type. return function(t) for i=1,1e9,3 do =================================================================== > > +-- 3) String representing the C type. > > -- Best regards, Sergey Kaplun