From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7EBA29E35C3; Tue, 6 Feb 2024 14:45:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7EBA29E35C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707219908; bh=QgN5Ftwbz9uBhG3BQmvhoSeDveQV0TUS07naEJWXRMs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vi1jUv6rrf3+TTRSE4C6xR9AB053GjaTfn+wHafYyzeOdfWcoBcNYuaAfsSiuGaV+ 9faCy8NZCkpdVeGYhFkrhJAoXjGXc/hvrUxcLX2aFVgNLzRoZwMnYpUtjaOr3mTqTr KA2y8ita38gRQtEb+/5wAdFC/58rMpYPP92fwpfw= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0CEAD9E35C3 for ; Tue, 6 Feb 2024 14:45:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0CEAD9E35C3 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1rXJsu-00000008iMp-3Sbh; Tue, 06 Feb 2024 14:45:05 +0300 Date: Tue, 6 Feb 2024 14:41:07 +0300 To: Sergey Bronnikov Message-ID: References: <0d003159c9a1811d98e30a863cc75c11bab658a3.1706104777.git.skaplun@tarantool.org> <38004fc1-a985-4cf5-98bd-d207360f753d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DE389E818B66C7AEF74583E9BFD0023CE34868C9E9FB1C391867C24CE74E72BB5FE18E9CBFBE7C0751F1622FC2B3474F5868188F228C8966D8136739924598654E91025664DCE6CDFEDCCBD3DDE7F493 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81B3CCDEF13AA107927297393C7ED0555D3F202A75A03981ECC7F00164DA146DAFE8445B8C89999728AA50765F790063793270F7220657A0A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352629B07FD02F83A6C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D4B17F35FE4B5C375002B1117B3ED696676E34F6A1E5C2368B25839F35DFE037823CB91A9FED034534781492E4B8EEAD32941D3B652364A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF42D49C427B794EC5B13FBF9584E3F4BCED28928A0AE7F0733977F81C3C0CF49490F5B3B6BD0F620E807D692F32DC7032CB5249AE5A9D06F388D8728F1A04FA3B8DF842998A05AE485F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMBFAhO+fZE4w== X-DA7885C5: DEBB9CF276D04AB0F255D290C0D534F98E4EB41F56A4BD45D156C44A2AF78085FF21B89A8E4637515B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33E97BD8D2D0A1EB5839430CFE978800FFB160BF827155AA46E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 06.02.24, Sergey Bronnikov wrote: > > On 2/6/24 13:07, Sergey Kaplun wrote: > > Hi, Sergey! > > Thanks for the review! > > > > On 06.02.24, Sergey Bronnikov wrote: > >> Hi, Sergey > >> > >> thanks for the patch! test is passed with reverted patch. Do you revert only this patch or the previous one too (or run just on the cloned master)? Because without the previous patch (1/2), the repro doesn't work. I've tried this flags locally and test is failed as expeced for GC64 and non-GC64 builds. > >> > >> > >> cmake -S . -B build -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > >> > >> cmake --builddir  build > >> > >> cmake --builddir build -t LuaJIT-tests > > CMake may cache LUAJIT_USE_SYSMALLOC flag, and test may not fail without > > it. Was this flag set? > > > only  -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON were used, see above > -- Best regards, Sergey Kaplun