From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6BF729E9E16; Tue, 6 Feb 2024 17:19:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6BF729E9E16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707229195; bh=KI9nMLCpo7ukF26awKy8MpuMw4BnZpkonorT7j3uGAY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KNjjdjPqM/3T74u7Q806qJxTKaAj9isdDfnxYeVr48pgTXf0f9K7W28ffhWlUZCWM S7mOw+Aq2flZbixqoz4DjVDa/npDIlRXnlJQqQrmcdeYo0mGONO3aHGpuC5kU2CbNf NlnhbrTi6jjgk2lpbyUTQBkBKquvnsAA29+u3ePQ= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9B7329E9E02 for ; Tue, 6 Feb 2024 17:19:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B7329E9E02 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1rXMIj-00000006RY9-3870; Tue, 06 Feb 2024 17:19:54 +0300 Date: Tue, 6 Feb 2024 17:15:56 +0300 To: Maxim Kokryashkin Message-ID: References: <0399f0ad011d742bd3f90777e7e5d9b64f26e6d2.1706520765.git.skaplun@tarantool.org> <2lngsqnj7bedymwutdfqi5vxsbv3onnz7pz3smlb3bp4sj2ia2@5zerlnx45qvd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2lngsqnj7bedymwutdfqi5vxsbv3onnz7pz3smlb3bp4sj2ia2@5zerlnx45qvd> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD94C460F083DF69F515295F69A3DCCED9A0936A66FF5CEBD44182A05F5380850404E84E7677813DCE72EB5D77EF37489D18B7C68D825D5E6A5EB7959DB07BACED7985936BB30EC2273 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637775FFFCA96730EC9EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8710ED4FB5646E0DA8EE7F37209960978EA4B032CF94C7F77DCA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CA5A41EBD8A3A0199FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F7900637F1CEADB5F7626D0D6D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637149D0840703ADBE5EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A571EC6BF66344896B5002B1117B3ED6965B68F3EC691F32304869453249F34FA4823CB91A9FED034534781492E4B8EEAD32941D3B652364A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF63F5B00CFCC1A2B02403417178249A155277F2A24D0733968B3FFB64E9DCB63D698455FC0CD9C182807D692F32DC70325C9C88B24611CD417A2AA9BF0494285FD1388D1B0FB166735F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMhpMi20WObmQ== X-DA7885C5: A0BAE82144CA6FA6F255D290C0D534F9329F86D635551FC1DD874A9225591DBF73410BEFE53AE6BB5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE337991F2CD912CBDACFDA5F80AB180BBF1712BE5F2340857AAE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 19/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment below. On 01.02.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > On Mon, Jan 29, 2024 at 01:45:19PM +0300, Sergey Kaplun wrote: > > +do --- checkfail > I would prefer a more elaborate name here. =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua index 3b49648c..b072cefb 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua @@ -3,7 +3,7 @@ local ffi = require("ffi") local checkfail = require("common.ffi.checkfail") local checktypes = require("common.ffi.checktypes") -do --- checkfail +do --- incorrect declarations checkfail{ "", " ", =================================================================== > > + checkfail{ -- Best regards, Sergey Kaplun