From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CAB3D9E9868; Tue, 6 Feb 2024 16:52:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CAB3D9E9868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707227551; bh=guhOja3tGmPOb3Wbrp/ib1p7Dk8d3THg8PkkFIsCepg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=y49TXakJBarmbZLGZpWJX2zFA18SLA+l5qhh0svuMzafCMKmHj/Z+xbcIRA3YUkCF XJbhgRQwlJ2YG4Z8s45bC1AtIKXkDGXrW/W7z9J1gDMmN3kMXbBceQMXDH5nTIVLAO UY+WNpHlOf91HG0NF+DQe7+04zSHagwdNN+bqhC0= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [95.163.41.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A8009E9863 for ; Tue, 6 Feb 2024 16:52:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A8009E9863 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1rXLsD-00000005xYD-1hj0; Tue, 06 Feb 2024 16:52:29 +0300 Date: Tue, 6 Feb 2024 16:48:32 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51696B3613FE7F7BC4ACE7C5A96F709F6D182A05F5380850402F185B33678E979AD27678DDAA806314F9F08FD9578D1E1F16FBF428892A7DDA0BB68142C3911900 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CD501AD3AF4FF0D5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B20ACC28402695E48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8379CEFEE54A49C1CDAE97AC2E9B61D3D03780C7B3E90B638CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FCF1175FABE1C0F9B6E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B779389CF6F126FEC75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A52FABB1831C94816E5002B1117B3ED69679E075729683E5384869453249F34FA4823CB91A9FED034534781492E4B8EEADE3800B164E348C91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFD33CC309D55D5EE4CBC7E4A9F244D76E26A24A2B302F17DEDA3DF757FCDD9B71A0D894938C2B729C807D692F32DC70323B0262128C996A9EE3A35A261D5C2A0681808E062719D3435F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMUlfr/gDmAJA== X-DA7885C5: FF54310BD4A5E020F255D290C0D534F99B26EB13050309A1DD874A9225591DBFFCDD5436728E368F5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE335AA99953AA209E484F19327E421EAA2CA26F6287E9E7B357E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 16/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment below. On 05.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with a minor comment > > On 1/29/24 13:45, Sergey Kaplun wrote: > > @@ -14,7 +14,7 @@ local function ptreq(a, b) > > return ffi.cast("void *", a) == ffi.cast("void *", b) > > end > > > > -do > > +do --- metatype index newindex > > isn't better: "metatype with index and newindex metamethods" or smthing > like this? > > This descriptions are for humans mostly and would be better to convert > these keywords to readable sentence. > > same for test names below Fixed. See the iterative patch below: =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua b/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua index b0054b1a..3fea5341 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua @@ -14,7 +14,7 @@ local function ptreq(a, b) return ffi.cast("void *", a) == ffi.cast("void *", b) end -do --- metatype index newindex +do --- metatype with index and newindex metamethods local nidx = {} local tp = ffi.metatype("idx1_t", { __index = { foo = 99, method = function(c, v) return v end }, @@ -45,7 +45,7 @@ do --- metatype index newindex fails(function(cp) cp.bar = 42 end, cp) end -do --- metatype index newindex with upvalues +do --- index and newindex metamethods use upvalues local uc, uk, uv local tp = ffi.metatype("idx2_t", { __index = function(c, k, x, y) @@ -78,7 +78,7 @@ do --- metatype index newindex with upvalues fails(function(p) p[0] = 11 end, p) end -do --- metatype index newindex with upvalues via setmetatable +do --- index and newindex metamethods as metaobjects use upvalues local uc, uk, uv local ti, tn = {}, {} local tp = ffi.metatype("idx3_t", { =================================================================== > > > jit_complex.lua -- Best regards, Sergey Kaplun