From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8F0C99E984F; Tue, 6 Feb 2024 16:37:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8F0C99E984F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707226636; bh=80J3XFIRXhPv+D1PhdGMR58I8K/70eM8I47Q3pJftcQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wedzHVu0X3wInzZsZhKKYlY4DKK2psbjOXt4n3LQ64MJ972Se0fGK+FMI3OClrBkT hQM2XqMUbEliUs4f1+99diMNA78t0w7/aJvV9eaLc5c0yuCwEhA/FbU1plWxnI7Ts0 yk1tjsFGX3pIeYC3q6stoQnrgin8xGj83XnVg6Dk= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9E1F69E984F for ; Tue, 6 Feb 2024 16:37:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9E1F69E984F Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1rXLdS-00000007TnS-1waN; Tue, 06 Feb 2024 16:37:14 +0300 Date: Tue, 6 Feb 2024 16:33:17 +0300 To: Sergey Bronnikov Message-ID: References: <45b12cbc615209e0017799101de44ff538f22b64.1706520765.git.skaplun@tarantool.org> <2c92df33-3e56-41ec-abc4-2656a49fa0db@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c92df33-3e56-41ec-abc4-2656a49fa0db@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F5190553CFE4D3947DFB7946331AD157781182A05F53808504023C1152AB9F1E9D491417EB218679B82829C3DC9F54AC4F19AAEDCCF9F6EA39E5AA816C561F801B6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE765F8192D394616BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370BEBC60587DC626C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8FA7EF6FBA080EEB080791EBB35861DB9EC3C1645D62B31A9CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC2EE5AD8F952D28FBE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B779389CF6F126FEC75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50BF8545646FD96065002B1117B3ED69679FB6F64E582D64C69995D676B7B4CBE823CB91A9FED034534781492E4B8EEAD32941D3B652364A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF27AA21B6982B732C31B2C4FE670A4DFF2C5383D2F7E741E19E003B4089F76BB70FDE042572883009807D692F32DC7032B7D796CCB500AAF4E6A703F80367E9043FDE5C4DB157FBDA5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnNgJfIYIVAnjA== X-DA7885C5: 32548AC3604F62A2F255D290C0D534F9A52D0655435C16164EFFA23D53D2C877E740E6D824F762015B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3326D03293252C0E3ED65A7C2A42C1CE5AFF77739B9C1FAFA0E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 14/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment below. On 05.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch. LGTM with a minor comment > > On 1/29/24 13:45, Sergey Kaplun wrote: > > +do --- ligud to pointer > typo: ligud -> lightud Fixed as the following (since the test name should be verbose): =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua index 0e64fe75..9edf67de 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua @@ -259,7 +259,7 @@ do --- int16_t array arithmetic assert(a[99] == 100) end -do --- ligud to pointer +do --- lightuserdata to pointer local ud = ctest.lightud(12345678) local s = ffi.new("struct { void *p; }") for i=1,100 do =================================================================== > -- Best regards, Sergey Kaplun