From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BA5979E9E02; Tue, 6 Feb 2024 17:16:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA5979E9E02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707229004; bh=Fp16eXzJhkdhjcA7NTKx0kK/FAoqhCRRFZLgHiYFJa8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Th/KtnZZIlyPHrBBXSGTqrWWTNjAIoz/XBBXn/MtUK1xnJwGcQj2CI8AnrOIU+d/c 2J2vPN7gZBkvUbNaW81ZMEPdLhsfXWx1zP9yvrIuLW19VsPOntx7SIB0DMQwa6xSP1 0ofhq5HWqIqhMPC5aCqlu6hN8nJNybF3jlUVGzfY= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 953389E9E0D for ; Tue, 6 Feb 2024 17:16:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 953389E9E0D Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1rXMFe-0000000AkgE-2VpX; Tue, 06 Feb 2024 17:16:43 +0300 Date: Tue, 6 Feb 2024 17:12:45 +0300 To: Sergey Bronnikov Message-ID: References: <2d1cb0d61396fbc7d6efd352ed540079df684477.1706520765.git.skaplun@tarantool.org> <72954849-cd6c-435d-a65d-d379674dabdc@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72954849-cd6c-435d-a65d-d379674dabdc@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD94C460F083DF69F515295F69A3DCCED9A65A8B27103DC31E2182A05F538085040A44871F1656495C8C591814E25D11F9F2D8917D07516C368EB7959DB07BACED7471E6F0AD5863D70 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74FC7AD0AD96C1577EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063704BED458119491218638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D802028C25D0EB3174FDFA2837F4B3BD9FD8181103EA11C0D7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2457FAF19517CF2C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D5B0D352177FDCC75002B1117B3ED696314919E23E95F9B1886DC9BC01168B20823CB91A9FED034534781492E4B8EEADE3800B164E348C91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7296E8768F6C5000C0041F210FB70F23AB6DFE4064775C91245036F8E89AB27E7D7FE2FA29F57787807D692F32DC7032CD52AB1DF9A7D93C276D5FB02227C01A190DCB04C9D44C0F5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnPb//h67UGZgg== X-DA7885C5: 60AED8F119BFD06BF255D290C0D534F91A1EB1821DEA67CD578DB32AB1DDB9E006E84D1BB7E614AE5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3354E781FDEBACEF464F7F07D62A3BF851FA2ABABEA35771CAE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment below. On 05.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM wit a minor comment > > On 1/29/24 13:45, Sergey Kaplun wrote: > > This patch changes `dofile()` (which uses an unreliable relative file > > path and mutates `_G` with global functions to be defined) to the > > corresponding `require()` of the helper functions. It adds groups with > > the names of subtests and enables the test in . > > > > Part of tarantool/tarantool#9398 > > --- > > test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua | 106 ++++++++++-------- > > test/LuaJIT-tests/lib/ffi/index | 1 + > > 2 files changed, 58 insertions(+), 49 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > > index 3a9616d7..d3b02759 100644 > > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > > @@ -1,58 +1,66 @@ > > local ffi = require("ffi") > > > > > -do > > +do --- sizeof VLA > > it is inconsistent with test name at least in a previous patch. > > Here: "sizeof VLA", in a previous patch "VLA". > > Feel free to ignore. Renamed as the following: =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua index d3b02759..ce82f5da 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua @@ -4,7 +4,7 @@ local checkfail = require("common.ffi.checkfail") local checktypes = require("common.ffi.checktypes") local fails = require("common.fails") -do --- checkfail +do --- incorrect declarations checkfail{ "int [", "int [-1]", @@ -33,8 +33,7 @@ do --- sizeof of arrays assert(ffi.sizeof("foo2_array_t") == 200) end - -do --- checktypes +do --- array declarations, sizeof() and alignof() local P = ffi.sizeof("void *") checktypes{ 10, 1, "char [10]", @@ -60,7 +59,7 @@ do --- checktypes } end -do --- sizeof VLA +do --- VLA sizeof assert(ffi.sizeof("int [?]", 10) == 4*10) local id = ffi.typeof("const short [?]") assert(ffi.sizeof(id, 10) == 2*10) @@ -72,7 +71,7 @@ do --- sizeof VLA assert(ffi.sizeof(id, 0x3fffffff) == 2*0x3fffffff) end -do --- sizeof VLS +do --- VLS sizeof assert(ffi.sizeof("struct { double x; int a[?]; }", 10) == 8+4*10) local id = ffi.typeof("struct { int x; short a[?]; }") assert(ffi.sizeof(id, 10) == 4+2*10) =================================================================== > > > jit_complex.lua -- Best regards, Sergey Kaplun