From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 54B5D9E9E16; Tue, 6 Feb 2024 17:15:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 54B5D9E9E16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707228937; bh=SF4tSL7zF22r1BFTTQE+ckwOx795J4hk71jPvqyBf9E=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CkFiTsGcEblit6C/YmUIZ1lV0wakyBb3lsdITTToaV8flSI46cgl/MCsPlbNjhHh6 Hjh9iv1GDwFxKAk7BRqQ7ys7HGJ+hGX/G+tBIP6qXka+sAiA4F6SActW2T+BqtCv80 ATnQT4WI9HLMv3oKmNB3YGfhBdws+hU6p4g6KfcM= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [95.163.41.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1D2779E9E02 for ; Tue, 6 Feb 2024 17:15:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D2779E9E02 Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1rXMEZ-00000007ht3-1tJ3; Tue, 06 Feb 2024 17:15:35 +0300 Date: Tue, 6 Feb 2024 17:11:37 +0300 To: Maxim Kokryashkin Message-ID: References: <2d1cb0d61396fbc7d6efd352ed540079df684477.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94C460F083DF69F5190553CFE4D3947DFAEC6AB1FF362D218182A05F5380850407DC6638FEB5F5E4391417EB218679B823EF0AF7828149A4ECBD7E2EA66A30C931B6A14438A2A01BA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C27E92EFAD44F80DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063725D748B084CAA27D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F023C0D7211E86D60BFD4EC509598CD17BA0E3548EC1E92ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2457FAF19517CF2C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5ACBA7DC64BDDC0B85002B1117B3ED696CE3C95BCC11E258E03803A57F48E4E5A823CB91A9FED034534781492E4B8EEADA367EA73E0D98AADBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF2364B564718676C9309CDEC38FE3E4CD8962C7A6AAF0375BA68E7348E85623F512B9ACBE231CC78A807D692F32DC70323CC83F201C700A6E191B27D0B0452DEF76D9582C1A999B2C5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnPt3rk4WoGaIw== X-DA7885C5: 58F2C5FD4D6C3549F255D290C0D534F926BB3932117F20DA2D3CE79B0FA7A403CF938A799B8CE1625B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3345E20690B30639785D6691311918E3FA9A1F0D3D35BF5B93E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Renamed test cases as you suggested: =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua index d3b02759..ce82f5da 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua @@ -4,7 +4,7 @@ local checkfail = require("common.ffi.checkfail") local checktypes = require("common.ffi.checktypes") local fails = require("common.fails") -do --- checkfail +do --- incorrect declarations checkfail{ "int [", "int [-1]", @@ -33,8 +33,7 @@ do --- sizeof of arrays assert(ffi.sizeof("foo2_array_t") == 200) end - -do --- checktypes +do --- array declarations, sizeof() and alignof() local P = ffi.sizeof("void *") checktypes{ 10, 1, "char [10]", @@ -60,7 +59,7 @@ do --- checktypes } end -do --- sizeof VLA +do --- VLA sizeof assert(ffi.sizeof("int [?]", 10) == 4*10) local id = ffi.typeof("const short [?]") assert(ffi.sizeof(id, 10) == 2*10) @@ -72,7 +71,7 @@ do --- sizeof VLA assert(ffi.sizeof(id, 0x3fffffff) == 2*0x3fffffff) end -do --- sizeof VLS +do --- VLS sizeof assert(ffi.sizeof("struct { double x; int a[?]; }", 10) == 8+4*10) local id = ffi.typeof("struct { int x; short a[?]; }") assert(ffi.sizeof(id, 10) == 4+2*10) =================================================================== On 01.02.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > On Mon, Jan 29, 2024 at 01:45:18PM +0300, Sergey Kaplun wrote: > > -- Best regards, Sergey Kaplun