From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CF8A89A65DB; Mon, 5 Feb 2024 12:57:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF8A89A65DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707127075; bh=HRxicgttI+bJzHN54JxkSvv1PjnJy4ugwSlItOMAGkg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZCTmjiMOFxbB9+pmyvNV33vIKjg7zyyv9JzSNoB3NW6yeQJy/75oa+hH+f8/fK/Ld Mbj0Ugt1qDpzNUhJRBLUmDhhjWmxrAu7sIrY2fdzrxLnrgWTUwcboFDt9rCN6KUrz/ qBmegKCZlzOXcyUkIshoaPX20ldippS5EcBo7juQ= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D21709A65DB for ; Mon, 5 Feb 2024 12:57:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D21709A65DB Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1rWvjd-00000004uj7-0GBA; Mon, 05 Feb 2024 12:57:53 +0300 Date: Mon, 5 Feb 2024 12:53:56 +0300 To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Message-ID: References: <20240112132643.106145-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DE389E818B66C7AE631C3FCB5F86392615F258C2698FF6161867C24CE74E72BB5FE18E9CBFBE7C07865D65F7DFD755CD053A566E509C333E20CDC55B46E235B1F507ABBEEE580C7B08D917D6130B1AFB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70C5E0F71D77D667BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F0D8FAB78312C5B48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AE220AB5059D17B53BE226D09787743E4E0006BEE1EB8C92CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73525A4AB119743A3B3C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A580E7D41DFFA9F6D25002B1117B3ED6963D409A2C09876852B48B7A7F94616420823CB91A9FED034534781492E4B8EEADBD39A56654533F91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3435B1F14A93C4073F53554781E138865F3F105F5600457693D27F6DBFA06AD3FEE34154F422DC5F501D7E09C32AA3244C3C742AE411700C7EAB70F9BE574AE9C64A09D3663AC626DBEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0TrRSEWQ3Vn45S+y+ZY/Rw== X-DA7885C5: B035162D4FAE0F50F255D290C0D534F903148FA5EF56CE9CE73B745B8696C2F947B6EEC8C906E0075B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE334FE7F81867EB1903CB5DF0A5AB0903D9D3B43E7361190606E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! LGTM, except a single nit below. On 02.02.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments, branch is force-pushed. > Here is the diff with changes: > New commit message: > === > LJ_GC64: Fix HREFK optimization. > > Contributed by XmiliaH. > > (cherry-picked from commit 91bc6b8ad1f373c1ce9003dc024b2e21fad0e444) > > In `lj_record_idx` when `ix->oldv` is the global nilnode and the > required key is not present in the table, it is possible to pass > the constant key lookup optimization condition because of the > `uint32_t` (`MSize`) overflow. Because of that, further recording > incorrectly removes the check for the nilnode, which produces > wrong results when trace is called for a different table. > > The issue is solved by using `GCSize`, which has a size of Minor: I'd say 'which size is defines by the target system' or something like that (to mention that it is 32 bit for non-GC64 build). > 64 bits, instead of `MSize`. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > === > > > > -- > > Best regards, > > Sergey Kaplun -- Best regards, Sergey Kaplun