From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A95B3A5A5DA; Thu, 15 Feb 2024 16:57:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A95B3A5A5DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005465; bh=k/OGDWT0TjmKGKh8BWjjDFaw2nLkSqnQ7Of/xYB4l0g=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FwUsHOIfltTceanYnvzT+DTmHxZQDEbH/gSxnM994ljmz4fXetRiHR1slrJVF0gI3 uT67+P3MyPCMoopHPGYYyDgGFWdon2VzfMynl/oJStD1r6tyu9LKLAQeYQbFvtqQyr c1ERuaAp82ZvvRVR632Xwc5KNj+7lg/DQ+l0cgjM= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0E60FA5A5DB for ; Thu, 15 Feb 2024 16:57:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0E60FA5A5DB Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1racF9-0000000FfhS-1yPi; Thu, 15 Feb 2024 16:57:39 +0300 Date: Thu, 15 Feb 2024 13:46:13 +0000 To: Sergey Kaplun Message-ID: References: <20240130150437.17133-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240130150437.17133-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD20213FE3C35E3505503959F43E1962753F3400894C459B0CD1B9FA712BB4B53EA28210B999B7BE3335B5D47E26900B0EC4EF406B99327490C560DEB93F7F06BD0150 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75644E22E05AA81AEB287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF176DF2183F8FC7C07FFAFB2D05C67BA58F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566D9DA136FD76E43AB49A0BEFC594EF8D3EB8C33A6A6660CBC1505102F30D3E502389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249E1D16C38C1488AB776E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B82742D4F9993F01B3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC2EE5AD8F952D28FBE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB9CEE4F2B4A90F8475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5DD65B473BAB0EBB15002B1117B3ED6961075298B55A16709B2920F75BA9A967F823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C95EC171CB2ECDEB9754BF7588DFE6E856B2549545C4715833742C5769ACF862E41D7E09C32AA3244CB8E67F17C68E12427215182CA7F28860626B0EFC704A95C7EA455F16B58544A21C197AAF4D2E4732E9CAF2BECF134D6894F255A82739648EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXEnhlQ2igEH/wA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5316605F424246C5446D77739F4E260083EB3409E47C577EDFE97B4359669AF64AEF5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix zero stripping in %g number formatting. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 30.01.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Reported by pwnhacker0x18. > > (cherry picked from commit 343ce0edaf3906a62022936175b2f5410024cbfc) > > In the situation when the precision (`prec`) and amount of digits > (`hilen`) for the decimal representation are the same and `ndhi` == 0, > the `ndlo` part will become 64 (the size of the `nd` stack buffer), and > the overflow occurs. > > This patch adds the corresponding mask (0x3f == 63) for the `ndlo` > incrementation result. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1149-g-number-formating > Tarantool PR: https://github.com/tarantool/tarantool/pull/9633 > > The test fails on M1 with the > timeout (see the example [1]). This fail is patch-unrelated, since I've > obscured this failure even for the branch without sources changes (tests > only). > > Related Issues: > * https://github.com/LuaJIT/LuaJIT/issues/1149 > * https://github.com/tarantool/tarantool/issues/9595 > > [1]: https://github.com/tarantool/luajit/actions/runs/7712549489/job/21020513973#step:8:5522 > > Duration of failed tests (seconds): > * 60.54 app-tap/gh-2717-no-quit-sigint.test.lua > > src/lj_strfmt_num.c | 3 ++- > .../lj-1149-g-number-formating-bufov.test.lua | 20 +++++++++++++++++++ > 2 files changed, 22 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-1149-g-number-formating-bufov.test.lua > > -- > 2.43.0 > -- Best regards, IM