From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E50A7A5A5C9; Thu, 15 Feb 2024 16:56:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E50A7A5A5C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005401; bh=hDat2s8qdAAdTu1UOXCJIbnJL8XSxpF+DtCS8+qpzPc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fLEALTifoRMSjNAhLIJF0U3i2UKz84gtuG8ryj8o3yd9H2lnKewjJ303J2YF5VZ+x klNh3stoUH1gGX7wduNcOIBKOjaPyB6BxPuXjQkRJg1YdGLN9Yx6/nqQ/W/cumkxSS d9XNwtcLh2C5KuLWxoVswrieH5Z7cUITst1jB/qc= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87CA3A5A5C9 for ; Thu, 15 Feb 2024 16:56:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87CA3A5A5C9 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1racEA-0000000GIUE-1hRL; Thu, 15 Feb 2024 16:56:38 +0300 Date: Thu, 15 Feb 2024 13:45:11 +0000 To: Sergey Kaplun Message-ID: References: <20240122110344.5401-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240122110344.5401-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD20214DC5FCE37C06C423E8156654C9386ABB00894C459B0CD1B9C2C10A4EE03414F0305B199291F3FFC4358D04C2C73646B862DB80D9278890391BB59B39F4C00062 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DD81BB19E5DE3F6B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A4C381258A158AA80C024F76FB3309F16B1417821D219861CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C2A336C65186350916E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C32F36E1858E9CF555BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C321259270BBF67A2035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5F8B4FCF46E7ADF845002B1117B3ED696B4B37A2CA2662CCEA9DAB4B68AE4D22F823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D18DB983EAD9E114099725A0A23CC80CD28012D66BEDDBD127510EB4A69C8FF63E1D7E09C32AA3244C176A53642BFF27F25DAF20B2795D94675CBB583395CE07CEEA455F16B58544A21C197AAF4D2E4732E9CAF2BECF134D6894F255A82739648EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXEmAvh7FrtzX4w== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5313CA5052A3176BA7172C88FB39F7EDAED8A5062BBC47B32FB0848A9FE748C21DCF5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Simplify handling of instable types in TNEW/TDUP load forwarding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 22.01.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Thanks to Peter Cawley. > > (cherry picked from commit c42c62e71a45a677b8b1cbf749bd33cf4d5918ff) > > This patch is a follow-up for the commit > b89186cb03e79359847cdbeb000a830cc464db35 ("Fix handling of instable > types in TNEW/TDUP load forwarding."). The problem still occurs when > TDUP load forwarding is performed for the boolean value. The > `fwd_ahload()` always takes the type of IR without checking the type of > the TValue for this iteration. > > This patch solves the issue by returning the expected type of the TValue > from the constant table (or `nil` for TNEW IR) instead. In the case of > type instability, the error in `loop_unroll()` will be raised, and the > loop will be unrolled for one more iteration to prevent inconsistencies. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-994-instable-pri-types > Tarantool PR: https://github.com/tarantool/tarantool/pull/9608 > Related issues: > * https://github.com/tarantool/tarantool/issues/9595 > * https://github.com/LuaJIT/LuaJIT/issues/994 > > src/lj_opt_mem.c | 20 +++++++++---------- > ...instable-types-during-loop-unroll.test.lua | 15 +++++++++++++- > 2 files changed, 23 insertions(+), 12 deletions(-) > > -- > 2.43.0 > -- Best regards, IM