From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D8B0CA5A5EA; Thu, 15 Feb 2024 16:58:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D8B0CA5A5EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005530; bh=iNwfk8fN2rx165iY3Og9FhqafJv5whlfxm99pi+BHIU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BlxPAIJDWXA4QprqXs3ZE0zX1nPdtOJxvAiQTn9Njd6hZpBvoEcJU+wYuLKdv7/E5 o4tI+H9O0/PXkFZf3hukCatPN3Q6/kXIXfBinasSjgcRgBrIqJl3Yk2CnAu2G5scC1 Jze1FEZqxQbkWW79c9KLfEaLBN6QrCJz7LQjo6tY= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 23EA3A5A5E5 for ; Thu, 15 Feb 2024 16:58:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 23EA3A5A5E5 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1racGG-0000000Ar7A-2Bcx; Thu, 15 Feb 2024 16:58:48 +0300 Date: Thu, 15 Feb 2024 13:47:22 +0000 To: Sergey Kaplun Message-ID: References: <20240207120648.12416-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240207120648.12416-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD2021FFAB9DE81764C590E5F67E848AD4FF6D00894C459B0CD1B9897A1AE2D1111C1F89A7A38B7ACD9A0A44085A71E0C93871BEC3B2A898069597F8D9167951636718 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721D130CF676D2164EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CD8995A08F41566CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD871469898C6433BE45CBFFEA23B80C83342A9781131EE7A4345A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE78A0F7C24A37A3D769FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF856009BA58C5E1BBBA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6EDF998CB16CCEE6976E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249957A4DEDD2346B42E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B642416645EBD45DC2089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5085172C9772DD5525002B1117B3ED696E054C10DF0216F254A0A47EBA01A636A823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBE059454CD56E5FD64C66601A2BBC3D8E2655E22D82FE0A67ECB3E49DF7D995E673DC415E80A8BD93168784816B2568428DFF2DB3E70779C343ED000786EA5B8A4812248EA4222C6C226CC413062362A913E6812662D5F2A74A26541E23E71317A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXEkmUxBDEgIQGQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5316D0DCA42012B10BB91CF6C6A8F7D6EF67251292941C699BE1B34330D38316A03F5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Avoid out-of-range number of results when compiling select(k, ...). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 07.02.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > The interpreter will throw and abort the trace, anyway. > > (cherry picked from commit 6ca580155b035fd369f193cdee59391b594a5028) > > The `recff_select()` sets the amount of `RecordFFData` structure even > for a negative first argument when trace is not recording (since the > interpreter will throw an error anyway). This leads to excess IR > emission and possible reads of dirty memory. > > This patch updates the `rd->nres` only in the case when a trace will be > recorded. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-ff-select-recording > Tarantool PR: https://github.com/tarantool/tarantool/pull/9659 > Related issue: https://github.com/tarantool/tarantool/issues/9595 > > src/lj_ffrecord.c | 2 +- > .../fix-ff-select-recording.test.lua | 44 +++++++++++++++++++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/fix-ff-select-recording.test.lua > > -- > 2.43.0 > -- Best regards, IM