From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Avoid assertion in case of stack overflow from stitched trace. Date: Thu, 15 Feb 2024 13:42:04 +0000 [thread overview] Message-ID: <Zc4UrGVpwtladvww@tarantool.org> (raw) In-Reply-To: <20231214114458.17929-1-m.kokryashkin@tarantool.org> Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 14.12.23, Maxim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by Sergey Bronnikov. Fixed by Sergey Kaplun. > > (cherry-picked from commit 1d75cd4d7be638babe6d4e47bf73ea05fc65d81c) > > When we exit from a stitched trace due to the Lua stack overflow > error, the Lua and JIT stacks are not synchronized, and they > won't be as long as the mentioned error is raised. Because of > that, we get the incorrect bytecode instruction in > `debug_framepc`. This patch fixes this behavior, so the > `debug_framepc` now returns `NO_BCPOS` for this case. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-913-avoid-assertion-stkov-from-stitched-trace > PR: https://github.com/tarantool/tarantool/pull/9484 > Issues: https://github.com/tarantool/tarantool/issues/9145 > https://github.com/LuaJIT/LuaJIT/issues/913 > > src/lj_debug.c | 9 +++++--- > ...-913-stackoverflow-stitched-trace.test.lua | 23 +++++++++++++++++++ > 2 files changed, 29 insertions(+), 3 deletions(-) > create mode 100644 test/tarantool-tests/lj-913-stackoverflow-stitched-trace.test.lua > <snipped> > -- > 2.43.0 > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 13:53 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-14 11:44 Maxim Kokryashkin via Tarantool-patches 2023-12-14 12:20 ` Sergey Kaplun via Tarantool-patches 2023-12-21 12:01 ` Maxim Kokryashkin via Tarantool-patches 2024-01-09 13:03 ` Sergey Kaplun via Tarantool-patches 2023-12-19 11:57 ` Sergey Bronnikov via Tarantool-patches 2024-02-15 13:42 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4UrGVpwtladvww@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] Avoid assertion in case of stack overflow from stitched trace.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox