From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2751CBDDCC9; Thu, 15 Feb 2024 16:54:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2751CBDDCC9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005294; bh=QwbvTZWl6XlawqPqnJrrTypllXMLyZkxJ+zlPqBK6AU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IE7I4VHv+odTaNm1P1eiAIe/pwzWD/I0FtCgYtg6+B8mAjcAiWoU0H+NicdRtv3Al tv6liDyxXIJ7vW7AmLnBh12VsU7dUU+2Lm3x0sb8rVvgPdkf6L4wEdomBO710ayrjP Y1A8td5r5jyvO1ZzhPGSEZKCVsArVfLk4h46A7WM= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 060D0BDDCC9 for ; Thu, 15 Feb 2024 16:54:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 060D0BDDCC9 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1racCO-0000000Elbk-3PB8; Thu, 15 Feb 2024 16:54:49 +0300 Date: Thu, 15 Feb 2024 13:43:22 +0000 To: Maksim Kokryashkin Message-ID: References: <20240202150801.80361-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240202150801.80361-1-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD2021721DFC1638C0DE020CB518295F388C0600894C459B0CD1B97B722505C171AD8078DB3C25428BC4E96ED62EA92C9E8DC258736E605CE1096F31E418E160CADA48 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E25DEE08FA4D750E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CE8448437C9DFFDC9C505E18649C5B37AAEAAE56F40BDBDFCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D886136E347CC761E074AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C38A6EFC3CE370B017BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3A1C30C8AFC676C8B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E9B891A313B3F9575002B1117B3ED6967465203C2C79D111957033528158102E823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A541DB4061E9383217C180D7303D0E7BEF0BF72568D7B1C3F82521FA705FC1287D9E4CB576A010BE1D7E09C32AA3244CC8F50C44D6088F07B58A6D757C7509E2AAF0540157B77735EA455F16B58544A2D06CB91D864A7BD2E9CAF2BECF134D6894F255A82739648EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXEkkunHoe4Ls0g== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53108E085C695FB37A395D4C5B18C328FC03612D40E7F9BA029A5AEA987AD96DDA6F5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] Fix recording of __concat metamethod. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 02.02.24, Maksim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall > > Reported by Elias Oelschner. Analyzed by XmiliaH. > > (cherry-picked from commit 3ee3c9cfa988339f1bf3068530515e2a6fb179d2) > > During the recording of `__concat` methametod, the `rec_mm_arith` > function overrides stack slots that are not restored for GC64 > mode later after the call. This leads to a segmentation fault > later on. This patch fixes the issue by accounting for those > additional slots in the array used for restoring stack values. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > Changes in v2: > - Fixed comments as per review by Sergey Kaplun > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-839-concat-recording > PR: https://github.com/tarantool/tarantool/pull/9597 > Issues: https://github.com/tarantool/tarantool/issues/9145 > https://github.com/luajit/luajit/issues/839 > > src/lj_record.c | 2 +- > .../lj-839-concat-recording.test.lua | 27 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-839-concat-recording.test.lua > > -- > 2.39.3 (Apple Git-145) > -- Best regards, IM