From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 64AE898B11A; Tue, 23 Jan 2024 16:14:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64AE898B11A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706015695; bh=skZKz2DNRBse54Pkgucbs9nV+fGVdUpoLsqgPn/XVJI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vVjOmEEvdazt9MIhcEr8FaoT6cLrbNdSik6Lr2UVZ1hHA10pbkwa+KUz5/UYlOF9o XkEelp/FQ6TxsLNIxUD1nr+Se3hXXWHhBZZQX22+uakb1FR4MwobSqSahlClMAoy1X JI1jRdZRcKmXHpHbh/H5lYNLDRljsPSZetH11/JE= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4FFF298B11A for ; Tue, 23 Jan 2024 16:14:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4FFF298B11A Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1rSGc9-00HJjv-29; Tue, 23 Jan 2024 16:14:54 +0300 Date: Tue, 23 Jan 2024 16:10:40 +0300 To: Sergey Bronnikov Message-ID: References: <7fe1885b-6ef2-4194-a5dd-e3d6b6a077ad@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fe1885b-6ef2-4194-a5dd-e3d6b6a077ad@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD936B5060B5AFFD5314FC64B4F3DF4614E040740DF0A7BE107182A05F538085040E6BCB6C185F4101C4465A634BC9A865B620AE30B810CA2B1FEF0FB7ABCCEEA16 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE779AAD18609327F83EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637829D9538242026C38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DCD1002A43681327B1D7AFC5BEB0AE6F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C088D2E8BEBF93D4B068655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C8BDE37D78FCB031643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5266F079531BB480AF09503AA6FD85E74EB92124CBCF2EAACF87CCE6106E1FC07E67D4AC08A07B9B0D2A98E5A6551E3E5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34023CA4E4726A7D6C7C421F598B759795005A71A80ACA9DF30D99F664C3DF88F29AEAFF4692F5D2CD1D7E09C32AA3244CBBD7B442F908F71E61FB9F91E5B97DEA5595C85A795C7BAE85A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSQVxX8i/5VNI10z6QD3Dg== X-DA7885C5: AF4D792A38903344A47DE7138B76E0DB5EBDBBC9AE1D18A4A4C979B3870F5D48262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33DE712EA02B975A47A38F5AC3A89E55C40FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 03/25] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 23.01.24, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch. > > On 1/19/24 14:32, Sergey Kaplun wrote: > > This patch changes `dofile()` to the corresponding `require()` of the > > helper function. It adds test names and includes the test in . > > What for do you need replace `dofile()` with `require()`? > > I believe it is important to say not only *what* commit do but also > *why* it do these changes. I added the following note to all commits mentioned this change: | (which uses an unreliable relative file path and mutates `_G` with | global functions to be defined) Branch is force-pushed. > > -- Best regards, Sergey Kaplun