From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2C17598B105; Tue, 23 Jan 2024 16:02:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2C17598B105 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706014973; bh=Xnzeh6tlmOP9rCzVfcgoOp4u3YbIO/BCev9B5lF9RAI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xMp8tpiDZpNjjcQ/lEpFW5Eu2WzFnjOlxDn45AngtySiMYipvgubo45yTHOoMf4rY WsvWrSrFmCqb8Xu/RyttFIZcYAmMqeKKan+O+3fkE4h79jxz2HnNu25NcFgBnlmDfo jG6P3Srz95geF09PT1lQTNDz32TGqd44Q8YEvVkU= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DE2D498B105 for ; Tue, 23 Jan 2024 16:02:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DE2D498B105 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1rSGQU-005tKN-18; Tue, 23 Jan 2024 16:02:50 +0300 Date: Tue, 23 Jan 2024 15:58:36 +0300 To: Sergey Bronnikov Message-ID: References: <8254ae42f1f9e872efecf156cfa0885156c934d9.1705661401.git.skaplun@tarantool.org> <02757523-a8d3-4d46-a47f-aeca721c9c9b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02757523-a8d3-4d46-a47f-aeca721c9c9b@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD936B5060B5AFFD5314D27A80ED572B8C33F567EA69625D425182A05F5380850401888687CDE45335167D165AD6C5E3FCD0C609364D8E7AE71159B78FB24ADCDFC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637790A9327A9AFEF4F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89EB1DB0B0E677CF7EAE8EC8BECE3DE33117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0FE3A47D6FA29121068655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C8BDE37D78FCB031643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5C6A8352AC8E8391D24B729E23D8C65B60986AC6E22B3140DF87CCE6106E1FC07E67D4AC08A07B9B017119E5299B287EECB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF9C3E42926298F526EEB5DB5D2FDECA0C5159BB9B261A4F09AE2CDFABF761309ECEAE7BAE235C0E404BEAD515961AA0A7C0656A6C6942441C83410DA411C64EF9E48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSQVxX8i/5UkCRAiSeiuwA== X-DA7885C5: 14B9E1B905B20586555809E48E46E2479CDB5AEB45AF6979B7C90F54CD822847262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33EFC200E2CDE6ECFD542816EEAE01A9650FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 06/25] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 23.01.24, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! > > see comments below > > On 1/19/24 14:32, Sergey Kaplun wrote: > > This patch names all subtests and includes the test in . > > The test with calls with 10 arguments with sizes less than 8 bits are > > dummy for M1. This suite lacks a mechanism to skip subtests satisfying > > complicated conditions, so it is done manually by the corresponding `if` > > check. > > > > Part of tarantool/tarantool#9398 > > --- > > test/LuaJIT-tests/lib/ffi/ffi_callback.lua | 33 +++++++++++----------- > > test/LuaJIT-tests/lib/ffi/index | 1 + > > 2 files changed, 18 insertions(+), 16 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_callback.lua b/test/LuaJIT-tests/lib/ffi/ffi_callback.lua > > index 1fd14bd0..253bf1d9 100644 > > --- a/test/LuaJIT-tests/lib/ffi/ffi_callback.lua > > +++ b/test/LuaJIT-tests/lib/ffi/ffi_callback.lua > > @@ -6,7 +6,7 @@ void qsort(void *base, size_t nmemb, size_t size, > > int (*compar)(const uint8_t *, const uint8_t *)); > > ]] > > > > -do > > +do --- blacklisted callback > > first letter should be uppercase and dot is missed in a comment, right? > > here and below As you mentioned, it is a test name, not a usual comment. Also, there is no strict style for test names in this suite -- there are with the uppercase first letter or lowcase, with a dot at the end of the sentence, and without. Welcome to the Wild West. > > > local cb = ffi.cast("int (*)(int, int, int)", function(a, b, c) > > return a+b+c > > end) > > @@ -19,7 +19,7 @@ do > > end > > end > > > > -do > > +do --- cast to function > > assert(ffi.cast("int64_t (*)(int64_t, int64_t, int64_t)", function(a, b, c) > > return a+b+c > > end)(12345678901234567LL, 70000000000000001LL, 10000000909090904LL) == > > @@ -37,11 +37,13 @@ do > > return a+b+c > > end)(7.125, -123.25, 9999.33) == 9883.205078125) > > > > - assert(ffi.cast("int (*)(int, int, int, int, int, int, int, int, int, int)", > > - function(a, b, c, d, e, f, g, h, i, j) > > - return a+b+c+d+e+f+g+h+i+j > > - end)(-42, 17, 12345, 9987, -100, 11, 51, 0x12345678, 338, -78901234) == > > - -42+17+12345+9987-100+11+51+0x12345678+338-78901234) > > + if not (jit.os == "OSX" and jit.arch == "arm64") then -- NYI > > + assert(ffi.cast("int (*)(int, int, int, int, int, int, int, int, int, int)", > > + function(a, b, c, d, e, f, g, h, i, j) > > + return a+b+c+d+e+f+g+h+i+j > > + end)(-42, 17, 12345, 9987, -100, 11, 51, 0x12345678, 338, -78901234) == > > + -42+17+12345+9987-100+11+51+0x12345678+338-78901234) > > My eyes are bleeding I can't read anymore... > > Why you cannot add more whitespaces to expressions? Obviously, there is room to improve this suite. Also, we don't refactor the whole test suite. It is not the point of this patchset, only enable some tests. This suite is just a good reference that Mike's (or ours) patches don't breake some parts of the LuaJIT. In the future we may reorganise these tests inside our own suite, for example. Now we have no resources for this, unfortunately. > > > > + end -- Best regards, Sergey Kaplun