From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6561A988B40; Tue, 23 Jan 2024 15:53:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6561A988B40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706014414; bh=88JlYiNhcxx1qS99XJ6aDltI4Y4SL1MuxlqTC86B9Ss=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dvn9RDeWVcoiaK3RBPEB5pIAcCTKggALzuUdigqOXmUlKkncj+vWm7Ehk+U8zA6tw 7trrcZwbCAcoT06oZRtPCEubiqDDRVM6Gw62usZ9aD85+rBeQeEnqHEc+2m2PwhJCp ICuC/5evZnsiYyz32j2hZY67LfFG4yRXzQrIJ2+0= Received: from smtp3.i.mail.ru (smtp3.i.mail.ru [95.163.41.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 16CF4988B61 for ; Tue, 23 Jan 2024 15:53:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 16CF4988B61 Received: by smtp3.i.mail.ru with esmtpa (envelope-from ) id 1rSGHU-00C2u2-1J; Tue, 23 Jan 2024 15:53:32 +0300 Date: Tue, 23 Jan 2024 15:49:19 +0300 To: Sergey Bronnikov Message-ID: References: <1869d003-786b-4171-8e4f-74938fffa701@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1869d003-786b-4171-8e4f-74938fffa701@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9E62ABF8986B18E620EA089B3A140F95D2C784B27FED6762D1313CFAB8367EF908E2BE116634AD74D8076F4F373D8CE3326F7F68D5AD5E2E3A5DD035371016521C9EA4D883D9778ED X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BEEB0D1ADA650026EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8718EF625BC76D5B865C6032C59B5435316CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD187441229DB5CFFAA63A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352686C055BC15B7FBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A53E1C013F362EBC53015F22841F60DF92DE0984AC4959E9A9F87CCE6106E1FC07E67D4AC08A07B9B017119E5299B287EECB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBB067A9727ABF605C7EBB87F67DDEEA7C5EAD247EBBECAE02EEDDD220A1EA98D760962882471415B4BEAD515961AA0A707053C88871831FB66F8C7BE21E71E3DE48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSQVxX8i/5Vsvv++y7p12w== X-DA7885C5: 415D157F797345D56B12264DC2378C9CB021D39DFD4557A1E1D5A562B3C6681B262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3398ACF52E658D04D365CF72FEFFA750020FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 07/25] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 23.01.24, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! > > see comment below > > On 1/19/24 14:32, Sergey Kaplun wrote: > > This patch changes the `dofile()` to the corresponding `require()`. > > Also, it names the only one test as "misc" and includes the test in > > . > > > > Part of tarantool/tarantool#9398 > > --- > > test/LuaJIT-tests/lib/ffi/ffi_const.lua | 4 ++-- > > test/LuaJIT-tests/lib/ffi/index | 1 + > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_const.lua b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > > index d42133ad..3213156d 100644 > > --- a/test/LuaJIT-tests/lib/ffi/ffi_const.lua > > +++ b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > > @@ -1,6 +1,6 @@ > > local ffi = require("ffi") > > > > -dofile("../common/ffi_util.inc") > > +local fails = require("common.fails") > > > > ffi.cdef[[ > > typedef struct s_t { > > @@ -41,7 +41,7 @@ typedef struct foo_t { > > } foo_t; > > ]] > > > > -do > > +do --- misc > Why three dashes? Three dashes are used before testcase name as a mark for test-runner. > > local foo_t = ffi.typeof("foo_t") > > local x = foo_t() > > > > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > > index 9a22104a..0a72daed 100644 > > --- a/test/LuaJIT-tests/lib/ffi/index > > +++ b/test/LuaJIT-tests/lib/ffi/index > > @@ -6,6 +6,7 @@ ffi_arith_ptr.lua > > ffi_bitfield.lua > > ffi_call.lua > > ffi_callback.lua > > +ffi_const.lua > > istype.lua > > jit_array.lua > > jit_complex.lua -- Best regards, Sergey Kaplun