Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v3 0/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*.
Date: Wed, 10 Jan 2024 08:52:07 +0000	[thread overview]
Message-ID: <ZZ5at3aR0D1tIv36@tarantool.org> (raw)
In-Reply-To: <20231004125034.64110-1-max.kokryashkin@gmail.com>

Max,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 04.10.23, Maksim Kokryashkin via Tarantool-patches wrote:
> Changes in v3:
> - Fixed comments as per review by Sergey
> - The patch was split into two, so the test case becomes easier to
> implement since it can now depend on this assertion instead
> of memory layout.
> 
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-624-jloop-snapshot-pc
> PR: https://github.com/tarantool/tarantool/pull/9166
> Issue: https://github.com/luajit/luajit/issues/624
> 
> Mike Pall (2):
>   snap: check J->pc is within its proto bytecode
>   Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*.
> 
>  src/lj_record.c                               |  9 +-
>  src/lj_snap.c                                 |  3 +
>  .../lj-624-jloop-snapshot-pc.test.lua         | 84 +++++++++++++++++++
>  3 files changed, 92 insertions(+), 4 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-624-jloop-snapshot-pc.test.lua
> 
> --
> 2.39.3 (Apple Git-145)
> 

-- 
Best regards,
IM

  parent reply	other threads:[~2024-01-10  8:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 12:50 Maksim Kokryashkin via Tarantool-patches
2023-10-04 12:50 ` [Tarantool-patches] [PATCH luajit v3 1/2] snap: check J->pc is within its proto bytecode Maksim Kokryashkin via Tarantool-patches
2023-10-10  8:05   ` Sergey Kaplun via Tarantool-patches
2023-11-26 15:12   ` Sergey Bronnikov via Tarantool-patches
2023-10-04 12:50 ` [Tarantool-patches] [PATCH luajit v3 2/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET* Maksim Kokryashkin via Tarantool-patches
2023-10-10  8:14   ` Sergey Kaplun via Tarantool-patches
2023-10-12 12:35     ` Maxim Kokryashkin via Tarantool-patches
2023-11-26 15:14   ` Sergey Bronnikov via Tarantool-patches
2024-01-10  8:52 ` Igor Munkin via Tarantool-patches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04 12:50 [Tarantool-patches] [PATCH luajit v3 0/2] " Maksim Kokryashkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZ5at3aR0D1tIv36@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH luajit v3 0/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox