From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix HREFK forwarding vs. table.clear(). Date: Wed, 10 Jan 2024 08:51:19 +0000 [thread overview] Message-ID: <ZZ5ah6IkfBv_OsdV@tarantool.org> (raw) In-Reply-To: <20231109122628.19853-1-skaplun@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 09.11.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by XmiliaH. > > (cherry-picked from commit d5a237eae03d2ad346f82390836371a952e9a286) > > When performing HREFK (and also ALOAD, HLOAD) forwarding optimization, > the `table.clear()` function call may be performed on the table operand > from HREFK between table creation and IR, from which value is forwarded. > This call isn't taken in the account, so it may lead to too optimistic > value-forwarding from NEWREF (and also ASTORE, HSTORE), or the omitted > type guard for HREFK operation. Therefore, this leads to incorrect trace > behaviour (for example, taking a non-nil value from the cleared table). > > This patch adds necessary checks for `table.clear()` calls. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-792-hrefk-table-clear > Tarantool PR: https://github.com/tarantool/tarantool/pull/9351 > Relate issues: > * https://github.com/LuaJIT/LuaJIT/issues/792 > * https://github.com/tarantool/tarantool/issues/9145 > > src/lj_opt_mem.c | 63 +++--- > .../lj-792-hrefk-table-clear.test.lua | 181 ++++++++++++++++++ > 2 files changed, 213 insertions(+), 31 deletions(-) > create mode 100644 test/tarantool-tests/lj-792-hrefk-table-clear.test.lua > <snipped> > -- > 2.42.0 > -- Best regards, IM
prev parent reply other threads:[~2024-01-10 8:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-09 12:26 Sergey Kaplun via Tarantool-patches 2023-11-10 12:49 ` Maxim Kokryashkin via Tarantool-patches 2023-11-13 7:37 ` Sergey Kaplun via Tarantool-patches 2023-11-15 11:46 ` Maxim Kokryashkin via Tarantool-patches 2023-11-22 15:25 ` Sergey Bronnikov via Tarantool-patches 2024-01-10 8:51 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZZ5ah6IkfBv_OsdV@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix HREFK forwarding vs. table.clear().' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox