From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 739ED93AB28; Wed, 10 Jan 2024 11:57:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 739ED93AB28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1704877027; bh=RFBNcns6PEMEn3Gd1rIY+39J64P4wso3WnPJoYGcpoE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YtXetFCfpRLFDknM6kOgWV4LsgTPUZSVgySeutrkpcFk4rXWFSDkRa34vIAGocZFj maKCciOPQQUju73GUYhV04YtCVJgVsj95z3TljA2CtfdULFk9l2ZJs8OW1+s+EFURy apOnqdQ2mmRTde0Yj+XHQ1Lt8UlmZr3LBsaiQxvA= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3970947EE61 for ; Wed, 10 Jan 2024 11:57:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3970947EE61 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1rNUOW-009Uyk-2O; Wed, 10 Jan 2024 11:57:05 +0300 Date: Wed, 10 Jan 2024 08:50:59 +0000 To: Maxim Kokryashkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F008C97756F746CA484E1B23D7B237301C4507AC9B9A7AAB182A05F5380850404AF600C39973CDF4E7A4EA57555B446C4E747E5FCD71E1F82495CB58DC1FAE5E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A4ECDDCF5F0B481EDE1A3728E45A79E8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B3DBBCB839D0549ACD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE368E4D7E803FA7AD5040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C062BEEFFB5F8EA3E2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F1FC58B5115ECA9A257739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A54C5A837CED08724AEDDC79FDD06067C1EC975A2F77FDD626F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D345CB6DE26F1654667FCC8D5FC735AECBF710480D5390CBE7902C29028DB318F69FE0848A587EBF35F1D7E09C32AA3244CB0E9914A16DECE37462F80F8AF20C82C64EE5813BBCA3A9DBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojou3Ii6fsdvVeukdQiQDG3w== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5313A1B002DACD62F344C21F795530C83323382E80AC58BC82D2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Pals, thanks for your reviews! I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 28.11.23, Igor Munkin wrote: > Hello there, > > The latter patch of the patchset provides the new approach for > deterministic testing for our sampling profiler. See more info in the > commit message. > > The first patch fixes the issue occurred while reimplementing the > sysprof test via fork(3) + ptrace(2): the output for prove was buffered > and hence duplicated when fork is done. I decided to turn of buffering > at all, since there is little sense in it for tests and nobody wants to > debug many (still unrevealed) related problems. > > I hope the approach will be moved to our utils for tests written in C, > but I do not see the whole picture at the moment, so the approach is > implemented for the only test being affected by the patch for #8594. > > Branch: https://github.com/tarantool/luajit/commits/imun/sysprof-ptrace-ffunc-test > CI: https://github.com/tarantool/luajit/commit/b48b905 > Tarantool CI: https://github.com/tarantool/tarantool/pull/9424 > Related issues: > * https://github.com/tarantool/tarantool/issues/9387 > * https://github.com/tarantool/tarantool/issues/8594 > * https://github.com/tarantool/tarantool/issues/7900 > > Igor Munkin (2): > test: disable buffering for the C test engine > test: rewrite sysprof test using managed execution > > .../gh-8594-sysprof-ffunc-crash.test.c | 269 ++++++++++++++++++ > test/tarantool-c-tests/test.c | 6 + > .../gh-8594-sysprof-ffunc-crash.test.lua | 55 ---- > 3 files changed, 275 insertions(+), 55 deletions(-) > create mode 100644 test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c > delete mode 100644 test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua > > -- > 2.39.2 > -- Best regards, IM