From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8FC5E72FA42; Tue, 12 Dec 2023 13:36:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FC5E72FA42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1702377412; bh=M6uyPxoAZ8JK80UZW1G3DYEAJlk4QcbXRmmr77tQrFs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SuDYTYuxLWC7kvWa2zSs3ZIOVtVgR9bEyOt2hERYbS4yGeOT4F3YVkx/jIHcGSGJd gYxhcgOgy3sR0V26N3Vaq4MlDxCcrmCIPjIDROr5cPeDqlZYuPlXbB3hAPYNUq16yv 4+eRwldwzkj7c4h6hTSxWLw+AnYm1bLYl7WGG6GM= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5C76A72F6D1 for ; Tue, 12 Dec 2023 13:36:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5C76A72F6D1 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1rD089-005ah5-2i; Tue, 12 Dec 2023 13:36:50 +0300 Date: Tue, 12 Dec 2023 13:32:17 +0300 To: Maxim Kokryashkin Message-ID: References: <3d34441cd94210ab916527ce95c8cba0ef1b8f4f.1701888856.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d34441cd94210ab916527ce95c8cba0ef1b8f4f.1701888856.git.m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97533543916A0F71AD286D97BFFE3DA5DB7E67E5414E74A44CD62213F67905E7A81B085DB3C7E340FC260A35C32B9123DA4D91D3827077C124787F701E02FBF3D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EBC3E7439A970C64EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372D850D7477D401F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BD36ACEA7514C384B86998ED1EE90E59117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD4782AAF36435267CD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D8803F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E6D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A51ECF544ED62B3572CC4DF7DE9C01148D7DE98A16635393DAF87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7EF81F36008F9C541C7AF8E4306B50642DDA827EF015E8CCB854F11214847C169F3638D7DAB8774B61E41F2809366B38656A3623DEE49D6E974C7E09ACB72017A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojm/AwjadTR3S7i9ujkM/yWw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76935229CA6903E646BD52011A0EFA6565AF43CCAED39DA92F1DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/6] build: fix tool components handling X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Please, consider my comments below. On 06.12.23, Maxim Kokryashkin wrote: > diff --git a/Makefile.original b/Makefile.original > index e67b6aa8..2a56d648 100644 > --- a/Makefile.original > +++ b/Makefile.original > @@ -95,7 +98,8 @@ FILES_JITLIB= bc.lua bcsave.lua dump.lua p.lua v.lua zone.lua \ > dis_arm64be.lua dis_ppc.lua dis_mips.lua dis_mipsel.lua \ > dis_mips64.lua dis_mips64el.lua vmdef.lua > FILES_UTILSLIB= avl.lua bufread.lua symtab.lua > -FILES_MEMPROFLIB= parse.lua humanize.lua > +FILES_MEMPROFLIB= parse.lua humanize.lua process.lua Minor: Please use the aphabetic order here instead. > +FILES_SYSPROFLIB= parse.lua > FILES_TOOLSLIB= memprof.lua I suppose we should include in `FILES_TOOLSLIB`. > > ifeq (,$(findstring Windows,$(OS))) > @@ -140,6 +144,7 @@ install: $(INSTALL_DEP) > diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt > index 1dfc39e4..a4adc15b 100644 > --- a/tools/CMakeLists.txt > +++ b/tools/CMakeLists.txt > -- > 2.43.0 > -- Best regards, Sergey Kaplun