From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8906F7115F5; Mon, 27 Nov 2023 13:42:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8906F7115F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701081762; bh=ZeX3Fqay4bX1L6e02x5gQXDMRWMooYdOMTnX8GDiWn8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uf40ciQUeV893FbZAkNu0JoEwwumj6lPVlU6FBTCYsUg88YGHq4dtdEoipcDPhdvL WauuA/SR4e2QaTEuX0VyB8Z6K6Z+s+QRZmiqaQtzMZn0yGHqAlQhbcyO0RRXWhqS+0 lZxocRZ2BZO62s7Mp+7PvrE2hhpY62LSPKJUP2Go= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ECCD5553E09 for ; Mon, 27 Nov 2023 13:42:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECCD5553E09 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1r7Z4Y-00GGqb-2U; Mon, 27 Nov 2023 13:42:39 +0300 Date: Mon, 27 Nov 2023 13:38:07 +0300 To: Sergey Bronnikov Message-ID: References: <20231114150455.2850-1-skaplun@tarantool.org> <47007825-9906-4f23-b719-79d822672e32@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47007825-9906-4f23-b719-79d822672e32@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91D46036009216274324BD24EF9083580926DD3E7EA7DEDE2182A05F538085040C8918A314690480A85D0220A0609786057BE87D2D415A9B23BF07852B652ACF0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73230F712CF4B3924EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378B49D47CE295E66E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BDB1E76C300EC338C4F0B68C1AB1003D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD20DA3B6C150F7642D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3DA7BFA4571439BB26E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FD2A95C73FD1EFF456D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A56E0BF5B2F2C03246CB9F3FEF16317FEFD7CCF45F4E8D1599F87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3474B2583E51315984D97F7F7FB29B85CEBD31B738F884478CB7A94F250099CB4541FF812F4230C69C1D7E09C32AA3244C97E781B51CB59F58934959921CF1B852408A6A02710B730485A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNlZijCPCuziRTdtcedm68Q== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7690583E0E3B76A7E0085D0220A06097860B67A942A63B4089ADEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for review! Fixed your comment, rebased on the current master and force-pushed the branch. On 24.11.23, Sergey Bronnikov wrote: > Hello, Sergey > > thanks for the patch! LGTM with a nit below. > > On 11/14/23 18:04, Sergey Kaplun wrote: > > +-- The instruction to be folded is the following: > > +-- 0016 p32 BUFPUT 0015 0011 > > +-- > > +-- The 0011 operand is PHI, which is not the last IR in the BUFSTR > > +-- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to > > +-- this resulting IR: > > +-- p32 BUFHDR 0010 APPEND > > +-- Which appends to buffer instead of reseting, so the resulting > > After rebase on tarantool/master and running LuaJIT-codespell: > > reseting ==> resetting Thanks, fixed! =================================================================== diff --git a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua index 19be91a4..98b83ece 100644 --- a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua +++ b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua @@ -35,7 +35,7 @@ jit.opt.start('hotloop=1') -- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to -- this resulting IR: -- p32 BUFHDR 0010 APPEND --- Which appends to buffer instead of reseting, so the resulting +-- Which appends to buffer instead of resetting, so the resulting -- string contains one more symbol. -- XXX: Use 5 iterations to run the variant part of the loop. =================================================================== > > > +-- string contains one more symbol. -- Best regards, Sergey Kaplun