From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 15572716A4C; Tue, 5 Dec 2023 11:49:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 15572716A4C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701766140; bh=NRAlp0vyQg2Q3j+9oQBOToL76uu3oHb9XkA/kFBpHRM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rsmb5rIQq5/fZjdqcikP6HWJn5ezvNWWl9EOHK5DAtdYgGsYBmjmPvZwRUg7V/eFB AaNFhrVaaqHi/DdSrxjj/dq83rn4h/JvhTm5pRk+zS0q0hgKjlAZF6ZF8aVKXeRCGu n72Zevh1LRTxgT5Zbt0ibT7yyTQsj3i45FlBkXQs= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [95.163.41.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CF55D70A88A for ; Tue, 5 Dec 2023 11:48:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF55D70A88A Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1rAR6v-00AMFj-2S; Tue, 05 Dec 2023 11:48:58 +0300 Date: Tue, 5 Dec 2023 11:44:20 +0300 To: Maxim Kokryashkin Message-ID: References: <3964980b22230aec346de0973392c3de8d0d244d.1701696044.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3964980b22230aec346de0973392c3de8d0d244d.1701696044.git.m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E76772819DE7E0C4B854F0CB6735A719AB182A05F5380850401BBE40D041AF94A838BC656A40CDAE4058936A9433D46256461B357B5502F940 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374F897F3E43A934888638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8442C06DDD55E45DE8B8144DF1B1B6328117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0406C186E56A1B26068655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C4DCCFF368A6260CFC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A51A9D61141CE9EA703F3CC4C80EC83C05B53BF95D14A621FAF87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D4E96E2A5B1100E0E53D689F235D6F1A03EF70E6B61330693E6EE0B74F08CFD9B34F2E587029C0661D7E09C32AA3244CB2D26E5863D6AE27A6536A7E75BAE931FE8DA44ABE2443F7BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojJEmydpeiNq94QxirBLk9Hw== X-DA7885C5: 53DAACFAC91F860D808102A6E5CDD26D0BF9D524019A9C8FF1980157D242BD1B262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33D158EF0A6B8946105E632C90B67015590FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/4] cmake: properly handle the memprof/process.lua X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Please consider my comment below. On 04.12.23, Maxim Kokryashkin wrote: > Prior to this patch, memprof/process.lua wasn't added to the > dependency list as a part of the memprof parser sources. Also, > it wasn't installed into the system along with other memprof > sources, which breaks the profile parser. > > Part of tarantool/tarantool#5994 > --- > tools/CMakeLists.txt | 2 ++ I suppose this patch should also add to the `FILES_MEMPROFLIB=` in the . Also, we should add sysprof libraries to the original Makefile. > -- > 2.43.0 > -- Best regards, Sergey Kaplun