From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B60408B7332; Mon, 4 Dec 2023 12:49:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B60408B7332 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701683362; bh=yHt63F9wea/SZm0RcOnrawAmop11DqilauKuxlnwrho=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cg9r43cXJJnGvURRUfQc0pylkLokOJEMxwDQb/HHhVEYYK6D5RWlZwku3273Ifsa6 C+XJhk2xcbBNHHlxeuQex0PewJoGDi2B/yo7xp1SmfcnQEKcLtfL+p2Siq+Pi792zP Jjg6D95qK0wG17VUiu7i9HAl5aA/NpCf71DgqLWI= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [95.163.41.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A9888B732F for ; Mon, 4 Dec 2023 12:49:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A9888B732F Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1rA5Zo-00DbRq-2f; Mon, 04 Dec 2023 12:49:21 +0300 Date: Mon, 4 Dec 2023 09:48:43 +0000 To: Maxim Kokryashkin Message-ID: References: <3tlmhrevpsdeyhzwb32wiuzchz4efwbcgjx5fc2owlg7luloq3@53a4cidfmhcw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3tlmhrevpsdeyhzwb32wiuzchz4efwbcgjx5fc2owlg7luloq3@53a4cidfmhcw> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E7835CCFA13113FE541E3AA15046475989182A05F53808504061AE9ACA277ADBA17CF861E9F168EDF73CB130325F7B3E216A67BD2D90262F13 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7466896EF24E80F12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764BF1E09E94CC6278638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AA329BBD8DF271DAE7FE9067B876A705117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA93DBBCB839D0549ACD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5989878029FC235857E7C4FDB0F3245F476CA2EF022DFA699F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AA8975497C7004E86B9D7727AEA962EC21997E3CDB28CAB193C855B2119F28A129B196E97C31C81A1D7E09C32AA3244C90F703503AA133480E5148E1E625751C1DD47778AE04E04D85A42E4C463514DC5DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAT457WPMCJxyIL7sWFP7tg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531B23AB27AA38E198A28F416CCC0093923D40DD477E283BB4B2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! On 03.12.23, Maxim Kokryashkin wrote: > Hi, Igor! > Thanks for the patch! > LGTM, except for a few typos in the commit message. > On Tue, Nov 28, 2023 at 02:53:16PM +0000, Igor Munkin wrote: > > Our testing engine for the tests implemented in C introduced in scope of > > the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce > > module for C tests") lazily flushes the TAP-formatted report to the > > . This might lead to a mess in a report e.g. in case when the > Typo: s/e.g. in case/, e.g.,/ > > particular case forks a child (that inherits its ) prior to TAP > Typo: s/TAP/the TAP/ > > header is yield to . Hence the patch disables buffering for > Typo: s/is yield/being yielded/ > Typo: s/Hence/Hence,/ > > before any part of the TAP-formatted report is printed. > > > > Follows up tarantool/tarantool#7900 The new commit message is below. ================================================================================ test: disable buffering for the C test engine Our testing engine for the tests implemented in C introduced in scope of the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce module for C tests") lazily flushes the TAP-formatted report to the . This might lead to a mess in a report e.g., in case when the particular case forks a child (that inherits its ) prior to the TAP header being yield to . Hence, the patch disables buffering for before any part of the TAP-formatted report is printed. Follows up tarantool/tarantool#7900 ================================================================================ > > > > Signed-off-by: Igor Munkin > > --- > > -- > > 2.39.2 > > -- Best regards, IM