From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2E5DE8BC6AF; Mon, 4 Dec 2023 11:51:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2E5DE8BC6AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701679891; bh=aQnK8GFMz1hqRGJ8wi9YF7DrXvdA1HXP7ufjiZMkOFU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LyQq2b5/CwMAlhihLDzUeBU2lEyNY0e7u4/35FiX5It0UBvV7On0Ru2+3LTiKOLOl 3ocYSOBBJcCfISY1j1s1/uP1dd1rnXybwG4VgzqKOw3i666E58BrPPkYWCsQadnTG9 +S6G5GNhnZPZhs+F9RzP3rrGcpdiFkMdlLeaWYKA= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [95.163.41.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6BE278BC6AE for ; Mon, 4 Dec 2023 11:51:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6BE278BC6AE Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1rA4fo-00DLMH-1j; Mon, 04 Dec 2023 11:51:28 +0300 Date: Mon, 4 Dec 2023 11:46:57 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E7CBAF789B6B32821FF6551DECFE8B152A182A05F5380850406244112C3AECDB6D30EF773711790D09A2B589503A267A075F3C903C4214079A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063753275FB77F6A31628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B29C4196639660DB1AF0B22FE707599D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0C70DDB8F70474A6A68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CD79BF8A03098E3B143847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A516DA283B369FF0D2AB97EEC0F1B8BC13E009ED81786A57A7F87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCCD7AE6CD937B301DE9E69EDAC0DBDD6DE8A1143E63EB02177728212FB1EE32224CDA40E848992A89157FEB932BFB23DB72DD0F64E02DEC82B1AC61B16533936E48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAT457WPMCJy4+nR12B1TCA== X-DA7885C5: 56DDF2B67E9661EA19F469028823662A0ED8529DFA199F564F1B722E898EA386262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3350ECD5769E009CBB41597DDA04391C050FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, after fixing Max's comments and my nit below. On 28.11.23, Igor Munkin wrote: > --- > test/tarantool-c-tests/test.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c > index 7907c12a..0a370cdd 100644 > --- a/test/tarantool-c-tests/test.c > +++ b/test/tarantool-c-tests/test.c > @@ -228,6 +228,12 @@ static int test_run(const struct test_unit *test, size_t test_number, > int _test_run_group(const char *group_name, const struct test_unit tests[], > size_t n_tests, void *test_state) > { > + /* > + * XXX: Disable buffering for stdout to not mess with the > + * output in case there are forking tests in the group. > + */ > + setvbuf(stdout, NULL, _IONBF, 0); So, we can remove `fflush(stdout);` in the `test_finish()`. > + > test_start_comment(group_name); > > level++; > -- > 2.39.2 > -- Best regards, Sergey Kaplun