From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ACB2D6E6CBD; Mon, 20 Nov 2023 14:27:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ACB2D6E6CBD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700479628; bh=zpOMVckCB2QkW0ldtJvdH2Z2KumZH9iPTVAJKU+bQv4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Z6pK+X2zg1M6pySiSWhneb1sksh5jqJYHh/YG0gG0xNdClUMFUcUNJuunQWiNOsiz YeJuIW7+4FoCHEw+rsQhx05AGEMtAW2zS0/TP+8yZ8zkAzqmboxN3Uz+sqRyFM9dK4 Z9G/lEdX78dBdvVJaeAI0L+tegieyu7ddSy9Ccng= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [95.163.41.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 35A8B6E6CBD for ; Mon, 20 Nov 2023 14:27:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 35A8B6E6CBD Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1r52Qj-00G2Fs-0a; Mon, 20 Nov 2023 14:27:05 +0300 Date: Mon, 20 Nov 2023 14:22:32 +0300 To: Maxim Kokryashkin Message-ID: References: <20231116134456.5898-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD93F1575C7510F5547926B4B9114735657696DFC1CFA9ECB9A00894C459B0CD1B9CC9314AEE4FF1E13FDA14458FC754E8C02C5EBA1E18267CA09C93364CE201E3D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779018AFA06A12C538638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84BC7C817E8323763D61340B4532CC035117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD03F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C369BF13FED57427F176E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C224952D31B9D28593E51E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D673F6B91EFC66D089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5D433F4F876293E35959CF5947DF11040F16693B7619904FAF87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AEC7C2AC3C44791D0480B8E1B02B7ADFE5BAA59E50514A19C5C7EA1BE3E52D7911617E818F1F1BDC1D7E09C32AA3244C6105033D3A9D3C21F9E8BC38D0C3291EE3D93501275E802F85A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmRIjd71J0y2N7/YrnoBelg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769AC5DF1D0A29DCD1C122B4026CF16EAA27345D355D45E21A6DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: add test for conversions folding X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment and force-pushed the branch. On 17.11.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit regarding the commit message. > On Thu, Nov 16, 2023 at 04:44:56PM +0300, Sergey Kaplun wrote: > > This patch adds the test for commit > > 1a401622fe83ae695226c94df3416e312315d659 ("Fix assertions."). This patch > > removes incorrect assertions in the fold optimizations for conversions > > from numbers to different integer types. Although the issue affects only > Typo: s/Although/Since/ Fixed, thanks. > > branch 2.0, there is no need to fix it. Nevertheless, the test is > > required to avoid regressions in the future. > > > > Part of tarantool/tarantool#9145 > > --- > > > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-833-fold-conv-from-num > > Tarantool PR: https://github.com/tarantool/tarantool/pull/9375 > > Related issues: > > * https://github.com/LuaJIT/LuaJIT/issues/833 > > * https://github.com/tarantool/tarantool/issues/9145 > > > > .../lj-833-fold-conv-from-num.test.lua | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 test/tarantool-tests/lj-833-fold-conv-from-num.test.lua > -- Best regards, Sergey Kaplun