From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 09A3B6B63EC; Mon, 13 Nov 2023 10:08:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 09A3B6B63EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699859333; bh=178ANOgWsKlpASkf6/WoFAyl0PW7jLuOPD8N/R+QAd0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=R1BX/3h5bouA3jc85AgqOA2HLpeOLoI4oL/oaJU4lz+Hmztwh/C5MD+GZZeffJcxw 6J+p8VQbY56GyviBYoHz4xi3X/bgyBtjvVt57ECx/1CbgRtWPzF+Kmh0IxMM6eflIi unImPqe6kj4Q3CyrgQ+RG7TgU9gLNpGoA9bjkp+M= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [95.163.41.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7E1EC6B63EC for ; Mon, 13 Nov 2023 10:08:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E1EC6B63EC Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1r2R3y-00GJs0-26; Mon, 13 Nov 2023 10:08:51 +0300 Date: Mon, 13 Nov 2023 10:04:16 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <350137386d2ce8f959cfe452e1355998fded73dd.1699534835.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <350137386d2ce8f959cfe452e1355998fded73dd.1699534835.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C2A6B03AB739174C98C7DD0DF98556B608BBEEF2999C341400894C459B0CD1B952A6F2495D0D2E317F490CE501F256BD9B654C1701C1F85014E64ECD1FAFC5AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EF59B520676799BC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E5C81A473B281BB7E33E370036CC721E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C16F36C0CB6DCE122BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6A56D0E915C5C7B293AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC3A703B70628EAD7BE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B015CA81987D179B8EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5CDFB351791863850AC77591C6012A465411A8D1EFCC30483F87CCE6106E1FC07E67D4AC08A07B9B01E44367C8E80A7B4CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34EE6683D9E546CC626008023ADBF6C445B8B62113571DDD8080AAD33002626F6D3CE97494A733121C1D7E09C32AA3244C0737D36AF3002FB533D50A412D39325ECE0B41342B755BCD85A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojg8Y/IM6oQGJ1baZ9C8qj1w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769FD3546814E3338F553E4C423D4C6EA5881AE5054A97140B9DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3][v2] Add 'cc' file type for saving bytecode. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch. LGTM, after fixing my nits below. On 09.11.23, Sergey Bronnikov wrote: > From: Mike Pall > > Contributed by Sergey Bronnikov. #1105 Minor: I suggest dropping #1105 here to avoid spamming to the ticket during development. > > (cherry picked from commit e826d0c101d750fac8334d71e221c50d8dbe236c) > > The patch adds a file type `cc` that allows exporting byte code directly > to a file with extension `.cc`. Typo: s/extension/the extension/ I suppose it is worth mentioning that the test will be added within future commits? > > Sergey Bronnikov: > * added the description > > Part of tarantool/tarantool#9145 > --- -- Best regards, Sergey Kaplun