From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 45EE36EC116; Thu, 23 Nov 2023 09:38:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 45EE36EC116 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700721497; bh=1RllTd60zux+y39IziMDwLBPJs38JXLOfA4l5S7wrDM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=u955hRTKrDSmIe908+UFu2fTol3bq1YrNyzHaJ/pAL3VIMSYlzXg8AGjD9xIgZ+iZ tsagXzEod0VnmZpIRm8w5dPPvzRoLQPX4zMXL0YQEaRa+ywIcVsac6YQtgUPxOgP2o /V4FuN9qt/2/5n0SIeJ/4iJr+wUvmhugq5Q9MC9A= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 51F0E6EB73C for ; Thu, 23 Nov 2023 09:36:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 51F0E6EB73C Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1r63Ji-00EfDw-0a; Thu, 23 Nov 2023 09:36:02 +0300 Date: Thu, 23 Nov 2023 06:31:38 +0000 To: Sergey Kaplun Message-ID: References: <20231116084959.24798-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231116084959.24798-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9FEA8E122FE2215F5F9A7F26A9461D4801668790ACF3513421867C24CE74E72BB5FE18E9CBFBE7C0795B41E2FB18240CF028BCA93543F5C6D27BE07829BF85B2E4DA8AD57119ECC7B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE749E89BD568380EECC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE71EAE3A63419E5AEDEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD871C2136D529A5E4A8EDDF6F18C4B6BC134CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D882D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3856009BA58C5E1BBBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF7EF884183F8E4D671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C321259270BBF67A2035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5A613176406028C36E9B7F3C9B0BE488DF16693B7619904FAF87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340A4C04F5DECA7EE9803BABA95BF4EC290070FDB90C33FF5DA921311F2B870BD1CC0162515B7355871D7E09C32AA3244C31BCA107AF80826CF16795B81E49FB0FE3D93501275E802FBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojOz05VK5QHNoUf/AX7yKFuQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5311A0CF5E08F56F5DADB200972796B169D059CFCCB8EA60E352326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Add NaN check to IR_NEWREF. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 16.11.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Thanks to Peter Cawley. > > (cherry-picked from commit 7f9907b4ed0870ba64342bcc4b26cff0a94540da) > > When emitting IR NEWREF, there is no check for a non-NaN stored key > value. Thus, when the NaN number value is given to trace, it may be > stored as a key. This patch adds the corresponding check. If fold > optimization is enabled, this IR EQ check is dropped if it references > CONV IR from any (unsigned) integer type since NaN can be created via > conversion from an integer. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1069-newref-nan-key > Tarantool PR: https://github.com/tarantool/tarantool/pull/9374 > Fuzzer link: https://oss-fuzz.com/testcase-detail/5251574662037504 > Relate issues: > * https://github.com/LuaJIT/LuaJIT/issues/1069 > * https://github.com/tarantool/tarantool/issues/9145 > > src/lj_opt_fold.c | 5 +- > src/lj_record.c | 12 +- > .../lj-1069-newref-nan-key.test.lua | 151 ++++++++++++++++++ > 3 files changed, 164 insertions(+), 4 deletions(-) > create mode 100644 test/tarantool-tests/lj-1069-newref-nan-key.test.lua > > -- > 2.42.0 > -- Best regards, IM