From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: fix flaky OOM error frame test
Date: Thu, 23 Nov 2023 06:32:31 +0000 [thread overview]
Message-ID: <ZV7x_3FBMRLpYrHv@tarantool.org> (raw)
In-Reply-To: <20231109134549.4905-1-max.kokryashkin@gmail.com>
Max,
I've checked this patch into tarantool/master branch in tarantool/luajit
and bumped a new version in master.
On 09.11.23, Maksim Kokryashkin via Tarantool-patches wrote:
> This test could do allocation outside of the protected frame,
> which could result in an uncaught OOM and test failure. This
> patch adds extra `collectgarbage` calls to the test to avoid
> such situations.
> ---
> Changes in v2:
> - Fixed comments as per review by Sergey Kaplun
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-1004-fix-flaky
> PR: https://github.com/tarantool/tarantool/pull/9318
> test/tarantool-tests/lj-1004-oom-error-frame.test.lua | 7 +++++++
> 1 file changed, 7 insertions(+)
>
<snipped>
> --
> 2.39.3 (Apple Git-145)
>
--
Best regards,
IM
prev parent reply other threads:[~2023-11-23 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 13:45 Maksim Kokryashkin via Tarantool-patches
2023-11-13 6:58 ` Sergey Kaplun via Tarantool-patches
2023-11-18 16:52 ` Sergey Bronnikov via Tarantool-patches
2023-11-18 17:55 ` Sergey Bronnikov via Tarantool-patches
2023-11-19 11:49 ` Maxim Kokryashkin via Tarantool-patches
2023-11-20 14:53 ` Igor Munkin via Tarantool-patches
2023-11-22 15:28 ` Sergey Bronnikov via Tarantool-patches
2023-11-22 15:30 ` Sergey Bronnikov via Tarantool-patches
2023-11-23 6:32 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV7x_3FBMRLpYrHv@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit v2] test: fix flaky OOM error frame test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox