From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 224586EB734; Thu, 23 Nov 2023 09:34:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 224586EB734 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700721287; bh=7JBe+is6yY2LcrkNw0pefL5lH0s+BI2ukLwBm6kfRyk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Cg1lKGdVGXD19ccXOR2Ypkqe7VqBAsCmEXMfaG8jrlDlfUnvFu6npUWwDkuG+nmqq iwpP9ox7PzArBSdaS09D1cP6CKTR98ed6edwNLiiyd/lXpwRjkqnrRESMnQCTn5UaC Z0vzxnG2cO1qX9HfZaH2AarDOsycYxM/bHUI8gLs= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 72F556EB732 for ; Thu, 23 Nov 2023 09:34:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 72F556EB732 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1r63Hv-00EVv9-1C; Thu, 23 Nov 2023 09:34:11 +0300 Date: Thu, 23 Nov 2023 06:29:47 +0000 To: Sergey Kaplun Message-ID: References: <20231107105418.18356-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231107105418.18356-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9FEA8E122FE2215F5F9A7F26A9461D4801668790ACF3513421867C24CE74E72BB5FE18E9CBFBE7C0731D8CEEA624E2BD7697B7A0958A76D25AF009FFC3F42093019B76541BFBA1C79 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE752E71F0C64B7C834EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80B86D51E23E6E49F720249B6F7BAFB2B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CA9FF340AA05FB58C2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C6D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A58DEA8DA9C9DDDACF458E6E83D988A42194C6C27787BA4A1BF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3430FC2BC1B917F018A4991DF0FE32ECD7D67F0A1FB579335428B53C489436B3EFE18E0C33C5E56D4D1D7E09C32AA3244C262B022802E1C4962A68B402BA8F4F1195A9E0DC41E9A4CFBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojOz05VK5QHNq9p6hRA66d0w== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5314F8A712061EFCA6D4C349D5CB794B5938070B02EA316FCEC2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] x64: Properly fix __call metamethod return dispatch. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 07.11.23, Sergey Kaplun wrote: > From: Mike Pall > > Reported by Sergey Kaplun. > > (cherry-picked from commit d133d67c881f363f0b5584ebd21a965eb3435aa1) > > This patch is the follow-up for the commit > 1672bdc0ffbee9f32fadb6943909d6af7eb9a7b1 ("x64: Fix __call metamethod > return dispatch."). This patch uses the incorrect macro x64 (which is > undefined in dasm) instead of X64. `KBASE` (r15d) is still compared > against `BASE` (edx) instead of `KBASEa` (r15) against rdx. > > This patch fixes the typo, so the correct registers are chosen. > > Sergey Kaplun: > * added the description for the problem > > Part of tarantool/tarantool#9145 > --- > > The test is omitted for the same reason as it was omitted in the 1672bdc > commit: it is too hard (or even impossible) to create the test case. > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1110-x64-return-dispatch > Tarantool PR: https://github.com/tarantool/tarantool/pull/9335 > Relate issues and PRs: > * https://github.com/LuaJIT/LuaJIT/pull/636 > * https://github.com/LuaJIT/LuaJIT/issues/1110 > * https://github.com/tarantool/tarantool/issues/9145 > > src/vm_x86.dasc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.42.0 > -- Best regards, IM