From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 80C075295FB; Wed, 8 Nov 2023 11:53:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 80C075295FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699433603; bh=nDrzWhcQjB61cvwO+4QHKURDxOPMQMhr9stRhA6reXw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=evy+aYAQRazUHmwaFSOmK8urT69VRAqN4Zb/fNJPAEB81mEZmZtGwGjHqHSb55KCi k3AKOpsJzHPr2W4r6wLvAJxiM1wppgjPPGHJ7YIjHHZLUIBjC0xtusTGvZyLUCQ8nF Z2QUkDWlX4ZuBug6gfkt50tiUpc3DuUgJ3P+7a6k= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66EDB504BEF for ; Wed, 8 Nov 2023 11:53:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66EDB504BEF Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1r0eJN-0003fV-LU; Wed, 08 Nov 2023 11:53:22 +0300 Date: Wed, 8 Nov 2023 11:48:49 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD99FFD3FA9E0A670D80A8086C0D77C39449349FB6B537DB8BD00894C459B0CD1B90C68CB322E2F2AE091271B15A8FB8CF55ACBD53592199F292F5D89ECF26BB078 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE772FD67E8B75B52AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374DF0C582D42FCA168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D818B55A680C30FEFB2B4455B1D66986F8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0C70DDB8F70474A6A68655334FD4449CB33AC447995A7AD1857739F23D657EF2BD5E8D9A59859A8B65D673F6B91EFC66D089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5D38E34AD76B178BA8C4F207BB2BCA1E26548D99C37BB8599F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D342E8FEDBD32DECB6D1257F3EA22D6DC47C41A6712118F2940BD73C3B36C9FD95C1D7084E5E62D41501D7E09C32AA3244C47C6945610B2BB0C298AEDEE6FDF1B7C408A6A02710B7304BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGx6zOZpnTNCVJK76afHiJg== X-DA7885C5: A82521962A0D4529F365D1265EA84F830E4F55B7D14509F043BA28F3AD6F2D95262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33F79C6B009D4907718C05B166F080F5050FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix C file generation in jit.bcsave. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, for the patch itself, just a question: Why do you remove the C file to check? I suppose it's good to check creation of a C file too. Thus we can avoid some regressions in the future. On 08.11.23, Sergey Bronnikov wrote: > Hello, Sergey > > On 10/31/23 16:21, Sergey Kaplun wrote: > > >>  add_custom_target(export_bc > >>    COMMAND ${CMAKE_COMMAND} -E > >>      env > >>        LUA_PATH=${LUA_PATH} > >>      ${LUAJIT_BINARY} -b ${LUA_FILE} ${C_FILE} > >> +  COMMAND ${CMAKE_COMMAND} -E > >> +    remove ${LUA_FILE} > >>    DEPENDS luajit-main ${LUA_FILE} > >>    BYPRODUCTS ${C_FILE} > >>    COMMENT "Exporting bytecode to a C file" > > The test still doesn't fail before the commit. > > The reason is that the C file is compiled by C compiler, not the C++ > > compiler (so this macro is irrelevant). > Fixed, thanks. > > > > I suppose that we should add a .cpp file for the test too (and add the > > LINKER_LANGUAGE CXX [1] property for this target if its necessary). > > Unfortunately, setting property with LINKER_LANGUAGE is not enough. > > Additionally one need setting CXX language for a project or enable CXX > in required CMakeLists.txt > > and it is better to have .cc extension for a file too. Otherwise CMake > fails to build a file by CXX compiler. Nice investigation, thanks! -- Best regards, Sergey Kaplun