From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A011783BBF9; Tue, 7 Nov 2023 21:44:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A011783BBF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699382697; bh=+NCajW25xLY3k2YgOjI8NWUCRg2CLPUhEsSyQSyD/SU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V0m6M9jUecIhNEE8sMT+yaBAnVkcm2mBBCm2IaGlKZAGTTLS0qWIWD7oblOenPp5Y HYyoc7TxhV9JL9r1S4hujcyUejzp+YPX5QGj03rGQlOlUoX9OMpU3WMf91sHdr/5i3 bPr0MlImE3N2FYktIMHmtj7+XyN1tTvIlPSZVMx4= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A86F183BBF9 for ; Tue, 7 Nov 2023 21:44:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A86F183BBF9 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1r0R42-005FA3-18; Tue, 07 Nov 2023 21:44:38 +0300 Date: Tue, 7 Nov 2023 18:42:31 +0000 To: Sergey Kaplun Message-ID: References: <2756cdf8d8a4be9aa55dfdadbd3453da067d8969.1697034851.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2756cdf8d8a4be9aa55dfdadbd3453da067d8969.1697034851.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99FFD3FA9E0A670D872D6E8EF47E992139A1F2E62EA148CC900894C459B0CD1B9996F5893B5C58253D2C2A2372495D335DB7142D2597CA5048E47C47A18F2969E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063753275FB77F6A31628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B99862DB521F8A6489B1CF31F81B4E7F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD4782AAF36435267CD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D8803F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CA9FF340AA05FB58C2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C5E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A507EC63C80166E37CC6B0CA4C5EFE68710986AC6E22B3140DF87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D344B4608D01B1CB59A321565A613DAE568F11AA9221D339A9C83D20CC832C3441870DAFDF6B134DDDE1D7E09C32AA3244CACD2FA5F246D26A13FE5227F1A5C57083C6EB905E3A8056BBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoiosMWyUVReituEuxDMXSw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531556BDA7BEF0A6CFC895E32899F59F0C3FDF4B8116AED59CF2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix base register coalescing in side trace. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except a typo below. On 11.10.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Thanks to Sergey Kaplun, NiLuJe and Peter Cawley. > > (cherry-picked from commit aa2db7ebd1267836af5221336ccb4e9b4aa8372d) > > The previous patch fixed just part of the problem with the register > coalesing. For example, the parent base register may be used inside the Typo: s/coalesing/coalescing. > parent or child register sets when it shouldn't. This leads to incorrect > register allocations, which may lead to crashes or undefined behaviour. > This patch fixes it by excluding the parent base register from both > register sets. > > The test case for this patch doesn't fail before the commit since it > requires specific register allocation, which is hard to construct and > very fragile. Due to the lack of ideal sync with the upstream > repository, the test is passed before the patch. > It should become correct in future patches. > > Resolves tarantool/tarantool#8767 > Part of tarantool/tarantool#9145 > > Sergey Kaplun: > * added the description and the test for the problem > --- > src/lj_asm.c | 7 +- > src/lj_asm_arm.h | 7 +- > src/lj_asm_arm64.h | 7 +- > src/lj_asm_mips.h | 8 +- > src/lj_asm_ppc.h | 8 +- > src/lj_asm_x86.h | 8 +- > .../lj-1031-asm-head-side-base-reg.test.lua | 139 ++++++++++++++++++ > 7 files changed, 163 insertions(+), 21 deletions(-) > create mode 100644 test/tarantool-tests/lj-1031-asm-head-side-base-reg.test.lua > > -- > 2.42.0 > -- Best regards, IM