From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 87EE06BF925; Tue, 31 Oct 2023 22:18:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87EE06BF925 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1698779937; bh=dKqX0jTfYGM5FH7JoLXG8meSb/qIgCncWdhApRddmZo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kJUYY6YfI70SGIcrkDm8/LidzmIpGadj3UKCbPlB0cNloKqybX3/4aJbQeJSsFuPW ugUSUBpQN/zCoMkonot/nsCUCKbQmqnCofTZnO+5KK4SZLmPIxet1xfAcJAEwnDG5L 6fB0B9QNuaIJO6UwMZYAaLhcLbtwBtymLC8qqP0U= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [95.163.41.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3A79D6BF91F for ; Tue, 31 Oct 2023 22:18:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A79D6BF91F Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1qxuGN-009vZH-0o; Tue, 31 Oct 2023 22:18:55 +0300 Date: Tue, 31 Oct 2023 19:17:50 +0000 To: Sergey Bronnikov Message-ID: References: <9b4befc22674bcc924ad74313d968d1748b85bd9.1698053812.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9b4befc22674bcc924ad74313d968d1748b85bd9.1698053812.git.sergeyb@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C931D0C4A91E71305C1FEC1D053E33D8A490E57900FE67C300894C459B0CD1B9D17BE4E394BF1AC8810BB77ABB2614BAC4D3E0179ED33ED11B6A14438A2A01BA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374A24022C550661178638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8659DD8432CBC25BBB28303A318173252117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C67F1C1C3ABB44F3A03F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C392AF71FE74A2456CBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFA12191B5F2BB86291DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55F76EDEDF3A76074CF9C49E62D20096CCAE5EE17E875C088F87CCE6106E1FC07E67D4AC08A07B9B067F1C1C3ABB44F3ACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34CAFBC0A7A4BEEE015EA5089C4C257AEE705A4D86B1346064500D386C7775D1DCAAD669999B4281051D7E09C32AA3244CB1C66AF98E4203ECC24158A33B75B25CC3B3ADDA61883BB5B8ECC449D0A488BD5DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPJ6ruIekffL12NIhnaGd0Q== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53151BC96FBB7171DFECDA645AA4F02E9ACEF5638EADA4E8A502326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit][v2] cmake: replace prove with CTest X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! I have some general comments prior to make more precise review for the particular changeset. 1. Unfortunately, the old scenario is broken: The recipe I used to run for building and running LuaJIT test is the following one: | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON && make -j test As a result of the changes, target doesn't build the dependencies (neither luajit per se, nor particular test helpers required to be compiled). So the recipe is transformed to this one: | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON | $ make -j # build LuaJIT | $ make -j tarantool-tests # run the particular suite to build the requirements | $ make -j tarantool-c-tests # ditto | $ make -j PUC-Rio-Lua-5.1-tests # some binary artefacts for Lua suite | $ make -j test Looks not such convenient comparing to the old mantra. 2. The new CTest targets should follow the existing naming practice (i.e. use the directory name, or its distinctive prefix), since the following command runs three suites. | $ ctest -L lua # runs lua, luajit and lua-harness 3. It looks like the logs will not be showed in CI to debug a hard-reproducible issue if one occurs. <--output-on-failure> can be a saviour here for us. 4. I'm afraid the current changes break integration with Tarantool tests. The reason is duplication of target both in LuaJIT and Tarantool build systems. AFAIU, moving under the condition similar to the one handled with LUAJIT_USE_TEST option doesn't solve the issue, since no test will be run as a result. Please check this part: it might be the main technical blocker for this changeset. 5. I remember that we're talking regarding running particular tests for all suites, but I see this is done only for tarantool* and lua-Harness. Is it experimental and you'll fix it later in scope of this PR? There is definitely the way to run a particular test in LuaJIT suite (AFAIR, you can just use its number). Regarding PUC-Rio-Lua-5.1 we can think about replacing all.lua as a runner as it's done in uJIT. I believe that's all for the starters. -- Best regards, IM