From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F8D36BE62B; Tue, 31 Oct 2023 20:26:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F8D36BE62B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1698773200; bh=xgyPQ9gRezo3ei7hNSvSUR2FgJU8o6fbxobspP+alGs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I7Cna8/zeL0YXW+SJ4undZ9vSQ3BXVu5qABeGZZFM4r/LYEuf1YRbMGKD7OZcbosP G4ybkeKK5/61iUqC9Bdwk+EdrVOWcnRrzb6IBYLmTxP5Jbn4nH73VRARUzljrCEI3z AeuYyXaLumQMDblCmTPKDKElXzDxohIaN6CJw3cM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D242E6B3EC6 for ; Tue, 31 Oct 2023 20:26:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D242E6B3EC6 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qxsVi-00026l-3H; Tue, 31 Oct 2023 20:26:38 +0300 Date: Tue, 31 Oct 2023 20:22:06 +0300 To: Maksim Kokryashkin Message-ID: References: <20231031160658.39846-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231031160658.39846-1-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C931D0C4A91E713028A6B45E8800B8D808196D39FA30EE0600894C459B0CD1B90E02A6E02A22A9BB0BE5BB46065CB5BECDC54136D568B50537AD88C62730AFDD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AC4684DF4EC4B256EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637329F9579A0E72DCC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85DA7CD2B000459E1FBC6BA4C0F8B3F6D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0406C186E56A1B26068655334FD4449CB33AC447995A7AD18262FEC7FBD7D1F5BD5E8D9A59859A8B6F7FD1A3A8AE6177F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A510F8448D601A9904BA24E4C8183E5AAA34FF96675A7EE5D9F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF506D2DA01826F3010AF6AFCC850E6B42EBABF8E0ECFA7342342D88D49D890E281D17C9D1E1925344516A7BA5748856629BC833BBF79F6448DE5A463F9D75FE70A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPJ6ruIekffI+gCHB6xz2Mw== X-DA7885C5: 0DF03073EE2367740154297B8C10BE5F6D65BEB3029552CFB1577ECBFA9126B9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B705832021D202918B8FE5376B269C8E80FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: disable tests for OOM on trace on *BSD X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Please, consider my comment below. On 31.10.23, Maksim Kokryashkin wrote: > These tests are flaky on *BSD, because JIT fails to allocate > the mcode memory. This patch disables them on *BSD platforms. IINM, the reason is not the OOM during "mcode" allocation -- we have similar allocator for BSD, so there are no differences here. The reason is that some objects are allocated outside protected frame, and there is no room for them. Also, it may strike on other platforms if Tarantool has more objects on the start, may not it? I suppose that to become bulletproof, the lj-1004 test should have `collectgarbage()` on the start and also the following lines with the correponding comment right after `pcall()`: | anchor_memory = nil | collectgarbage() I beleive that after such changes there is no need in skipcond for BSD. So, the gh-7745 has the following lines, and I see no flaky failures for him. Can you provide the CI links where the test fails? > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-1004-fix-flaky > PR: https://github.com/tarantool/tarantool/pull/9318 > test/tarantool-tests/gh-7745-oom-on-trace.test.lua | 2 ++ > test/tarantool-tests/lj-1004-oom-error-frame.test.lua | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/test/tarantool-tests/gh-7745-oom-on-trace.test.lua b/test/tarantool-tests/gh-7745-oom-on-trace.test.lua > index 9ac41ac7..e700f081 100644 > --- a/test/tarantool-tests/gh-7745-oom-on-trace.test.lua > +++ b/test/tarantool-tests/gh-7745-oom-on-trace.test.lua > @@ -7,6 +7,8 @@ local test = tap.test('OOM on trace'):skipcond({ > (jit.os == 'OSX'), > ['Disabled on MacOS due to #8652'] = jit.os == 'OSX', > ['Test requires JIT enabled'] = not jit.status(), > + -- OOM during the trace mcode allocation. > + ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', > }) > > test:plan(1) > diff --git a/test/tarantool-tests/lj-1004-oom-error-frame.test.lua b/test/tarantool-tests/lj-1004-oom-error-frame.test.lua > index 3be6b555..8f831177 100644 > --- a/test/tarantool-tests/lj-1004-oom-error-frame.test.lua > +++ b/test/tarantool-tests/lj-1004-oom-error-frame.test.lua > @@ -4,6 +4,8 @@ local test = tap.test('lj-1004-oom-error-frame'):skipcond({ > ['Test requires JIT enabled'] = not jit.status(), > ['Test requires GC64 mode disabled'] = ffi.abi('gc64'), > ['Disabled on MacOS due to #8652'] = jit.os == 'OSX', > + -- OOM during the trace mcode allocation. > + ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', > }) > > test:plan(2) > -- > 2.39.3 (Apple Git-145) > -- Best regards, Sergey Kaplun