From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4E9AC65341F; Wed, 25 Oct 2023 13:23:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E9AC65341F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1698229412; bh=45d1pdn7vHrdCKhSC7mrY7R4EC+qH5u3s/QBfG09EVI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dqHukY66ih6c10KldC6C/nxgWWizd/y7eJxpT42N2eqsHCGap5WRmPdajrbtC3kh5 OttMiEY5lYjJoNJv5nCnQW6zViT7yibw97KFh2Uf8uJptW8jvO8UmMEqotng9gVi/D MdVWjA2yRow3LI8l7MZFWeyliUGje/Xw3qUTg1lc= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D119665341F for ; Wed, 25 Oct 2023 13:23:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D119665341F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qvb2v-0001Ue-Q0; Wed, 25 Oct 2023 13:23:30 +0300 Date: Wed, 25 Oct 2023 13:19:00 +0300 To: Maxim Kokryashkin Message-ID: References: <30f685beb2bf4ce39dd82ede7b10c821af5c6f0d.1698049570.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9315D6E1B1B5C3D6DE053FBAFB698D98948E7CEA69FECEC8100894C459B0CD1B954EEAA69581BE0AC719B4C1458A30EA376EC6F655987BE4DB14F0FA0E0289DA8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F5B2F26146BDF5648638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8827299BDB41DB9A18195E07184E2353B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C03E69C4AB24A3574568655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CDA0371536F40842743847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5F35B600A8C4B8928D80DC8187102E90672085C2E35955831F87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34BF5454112BD5BFD78305BB8890149C98EA91FAB0FB940E4188C4DB17B0A887DC46B2D1B99ED0AC651D7E09C32AA3244C5F4C52D4761EAA454F1B44BF981BBEECB038C9161EF167A185A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7UiV2qa299pNWILGe0vW3Q== X-DA7885C5: 964A460D5D27B9A9E9D5A7D63CB30986CE6F028A431FD78F92C26968C4FF7D16262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B6FE5BA3B99849F5DE8AA12832BE09F180FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/6] FFI: Fix missing cts->L initialization in argv2ctype(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Please, consider my answer below. On 24.10.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits regarding the commit message. > On Mon, Oct 23, 2023 at 12:22:02PM +0300, Sergey Kaplun wrote: > > From: Mike Pall > > > > (cherry-picked from commit 50d6883e6027c4c2f9a5e495fee6b7fff1bd73c9) > Incorrect hash, should be: a622e2eb559c823d90c7af85935ca63706e4593d > > > > When start trace recording without an initialized `L` in CType State > > (possible if the recording is started before any `ffi` library usage), > > the corresponding assertion fails in the `lj_ctype_intern()`. This patch > > adds missing initialization during recording. > > Please explicitly mention that the test case fails only when the LuaJIT > is built with -DLUA_USE_ASSERT=ON. > > the corresponding assertion fails in the `lj_ctype_intern()`. This patch It's obvious since there are no assertions if this option is set to OFF. So, ignoring. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#9145 > > --- > > Best regards, > Maxim Kokryashkin > -- Best regards, Sergey Kaplun