From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 945CA5042C1; Tue, 10 Oct 2023 11:19:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 945CA5042C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1696925947; bh=bJfbOnCNazZda0nhDrsibzLDdPKzNFTzZOknFnb1zTQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cBRhyd1kYV72qwVN0Coifdai69htWlJaXUVDK0jZe25ktUR/lB+D1Snxl4VIhmlky w0gXTqE/fhJYPVkK/bR7tefhzOMqWpjRciROZAgXos2D4oErm/ldXq9jwHKQq+asA3 wNm+f+t7bKK0o4gBUYavt7vipmHfF+RLtdybHvB4= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B99065042C1 for ; Tue, 10 Oct 2023 11:19:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B99065042C1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qq7xI-0000wJ-Po; Tue, 10 Oct 2023 11:19:05 +0300 Date: Tue, 10 Oct 2023 11:14:36 +0300 To: Maksim Kokryashkin Message-ID: References: <20231004125034.64110-1-max.kokryashkin@gmail.com> <20231004125034.64110-3-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231004125034.64110-3-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FE0487E502468146151CFFDF2BBA58DC1B080ACA52AE241C00894C459B0CD1B93F0747523A1B72E1B78E65A4E5D71F66777291A2F2A1DBE2FE100A7AB8CE52E2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375DA0115FC9FAE6C68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89F069D758F8F65ACEBA143AA0C2777A9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC55B19328CBC4F849A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0D75EB778CE7D8A0C68655334FD4449CB33AC447995A7AD1857739F23D657EF2BD5E8D9A59859A8B6F82A78844E5C6993089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A59C845207C7D8810517A77B173904D4037C03CD24345857ABF87CCE6106E1FC07E67D4AC08A07B9B08ED1AC82D843A2BBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6756167007514E7304A0647C7A68359CA99E406FEB898DF5DA43A395E6FA8A04212E5196DFD6A13FED8146B44B59358909D070AFCD59982751589EB3D339C77FA74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7Bv9MRqw1O3tyON/vLc04Q== X-DA7885C5: 640F8542802E87D3D63977CC615C1D93775A1DF168747544378B2F6CC00ABB87262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B7C96C4561C999A77E744FA1D81C307400FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, just a few nits regarding to the comments in the test. On 04.10.23, Maksim Kokryashkin wrote: > From: Mike Pall > > diff --git a/test/tarantool-tests/lj-624-jloop-snapshot-pc.test.lua b/test/tarantool-tests/lj-624-jloop-snapshot-pc.test.lua > +-- > +-- ---- TRACE 2 exit 1 > +-- ---- TRACE 4 start 2/1 test.lua:3 > +-- 0013 RET1 1 2 > +-- 0012 ADDVV 1 1 2 > +-- 0013 JLOOP 3 3 > +-- > +-- During the recording of the latter JLOOP the assertion added > +-- in the patch is triggered. Minor: I suggest to rephrase this as the following: | The assertion introduced in the previous patch is triggered during | recording of the last 0013 JLOOP. > +-- > +-- See also: > +-- https://github.com/luaJIT/LuaJIT/issues/624 > + > + Nit: extra empty line. > +jit.opt.start('hotloop=1', 'hotexit=1') > +local function fib(n) > + return n < 2 and n or fib(n - 1) + fib(n - 2) > +end > + > +fib(5) > + > +test:ok(true, 'snapshot pc is correct') > +test:done(true) > -- > 2.39.3 (Apple Git-145) > -- Best regards, Sergey Kaplun