From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8AA0C671473; Mon, 9 Oct 2023 12:18:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8AA0C671473 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1696843102; bh=dxGtgLGHL4UNc3w9HOdX0T1Atp8NBlwpJsjOifWe3Tg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MWFjTVf76DXzi+qBaZ/TS1P3NJMayLUt3f9DpHwIYA608nDuGY/uqEIiZjYd/17gX ymztY0tIisNPHb/HwYpm5h7ksxK2FBky6oq7e3L+bT+rWKV58gRLwuwPPcvWqcqzsn v8Pk1ZxxmF1xDyydyMDs8Q8YwQ6wYviH9XxjVCds= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 52CA05771B4 for ; Mon, 9 Oct 2023 12:18:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 52CA05771B4 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qpmP6-0003hv-53; Mon, 09 Oct 2023 12:18:20 +0300 Date: Mon, 9 Oct 2023 12:13:51 +0300 To: Maksim Kokryashkin Message-ID: References: <20231003151133.13730-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231003151133.13730-1-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD933FC8430F337940E2ACA3A34BCBF2156C581995C4D279C75182A05F5380850404C228DA9ACA6FE2789E7CA5400A067CF79573E2B907EE23A2101198B003CECCC4F79DA0443DB7BF1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE705B093C0FC4B30B9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374FBED2B83F5E00CA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88837DF2279999AEFBBF93FF9500C6561117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B68E8C7CA30B58DD5D089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58B259A6EA69C09F907C2D905710C98A6D4C97928F7911947F87CCE6106E1FC07E67D4AC08A07B9B09E541A154B51D14BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E9B0C12ABED5513716D367D339085275A4DD9023886F461432B22D8EFEF1C631B48E4840D06457081D7E09C32AA3244C5EADFEE6ADADA78F350967AFD5F9DC666C24832127668422BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEbds4VBqihSuXHimPrVd7A== X-DA7885C5: CD815F41ACBF7A97748F8275387C0D2F0B26080133A14AC23875EC75C4C21605262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B8C11F0A4DE9B7BCC8DC139A6594B9BFC0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix Clang build. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max! Thanks for the patch! Please, consider my comment below. On 03.10.23, Maksim Kokryashkin wrote: > From: Mike Pall > > > No tests were added since the issue is relevant for a very > specific type of very old clang 10.0.0, which is not really > relevant for us. Indeed, but we should add the testing of clang build to our CI. I suppose we may check the following matrix: - [GC64, !GC64] - [Debug, Release] - Linux only ARM64 may be omitted for now since it isn't our target platform. It should be done aside from ASAN testing just to verify correctness under this compiler. Should be easily added to the `test-luajit` matrix in the <.github/workflows/testing.yml>: > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#9145 > --- > PR: https://github.com/tarantool/tarantool/pull/9215 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build > Issue: https://github.com/luajit/luajit/issues/595 -- Best regards, Sergey Kaplun