From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C4CD364D12D; Mon, 18 Sep 2023 11:01:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4CD364D12D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1695024092; bh=k4d8eDRna3UZ+J8TGsUT5ADx5JjRBZkpZ8S0UHORCYU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uLsXFArOoeM7OWkJEPyudcXanP9n4MiL4kqWLipajSlh8rlVlulm4gfRJPm6xdEcJ GM//Wotr5Mm4pvvneTyPnXKN9e5cVc3glDpIZPxxpaCeNRaQS8WtxbATqhlouvBwrC 2NWwIIax/aSwMYvhnhkOir3xF4s6lra2xNt8GYeA= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 10E0D4242D4 for ; Mon, 18 Sep 2023 11:01:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10E0D4242D4 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1qi9CE-00FaHj-0j; Mon, 18 Sep 2023 11:01:30 +0300 Date: Mon, 18 Sep 2023 10:56:52 +0300 To: Sergey Bronnikov Message-ID: References: <20230829123641.3303-1-skaplun@tarantool.org> <9e40b101-6a55-4961-0eda-7c8a955deb13@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e40b101-6a55-4961-0eda-7c8a955deb13@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FD052C19707CBA10E1AA45CA4E1CD71251F2551E4E8EBD4500894C459B0CD1B93B60F8DA911D035EE06CB282775BF45C3EE07CAA630130414A9DBE0811142006 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E357932315C0A3C4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379D5D247705B2C2C78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EFA464ED67CA0475DCE5C2E4CB5B95FB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE652FD71AFB96DC7D6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3ED84CD51639A6C1F76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB33AC447995A7AD18C6EABA9B74D0DA47D5E8D9A59859A8B6598BD4784909AC60089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51E6C1079A4F6B1B72D9A17B947409E0444F832A2B2FFB660F87CCE6106E1FC07E67D4AC08A07B9B065B78C30F681404DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF2D54D5CF249A31F30730D5726ADEFBB034CE3D078FF8DBE668A4E24056B61DFD8D4FFD5EE536539970502DB933AA346E7BAC5B7E78B8E580889C0375ED67B40DE48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYZAGv/D6+030VrboNC5UFw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76914FD96BB65ADEED3A690BF0D3CB515C87AD558DE3329E344DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Handle table unsinking in the presence of IRFL_TAB_NOMM. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment below. On 16.09.23, Sergey Bronnikov wrote: > Hi, Sergey > > > Thanks for the patch! LGTM > > See a minor comment below. > > +jit.opt.start('hotloop=1') > > + > > +local counter = 0 > > +local slot = 'slot' > > +while true do > > You are using endless loop here, but loop is limited by 3 iterations > (break after counter > 2). > > Why "while true do end" is used here? Should we left a comment here? > Added the following comment, as you suggested. Branch is force-pushed. =================================================================== diff --git a/test/tarantool-tests/lj-1052-unsink-with-irfl-tab-nomm.test.lua b/test/tarantool-tests/lj-1052-unsink-with-irfl-tab-nomm.test.lua index aaf5349f..eaf89501 100644 --- a/test/tarantool-tests/lj-1052-unsink-with-irfl-tab-nomm.test.lua +++ b/test/tarantool-tests/lj-1052-unsink-with-irfl-tab-nomm.test.lua @@ -16,6 +16,9 @@ jit.opt.start('hotloop=1') local counter = 0 local slot = 'slot' +-- XXX: The loop is limited to 3 iterations to compile a trace and +-- start to execute it. Use the `while true do` loop format to see +-- the side effects on the restoration from the snapshot. while true do counter = counter + 1 -- Use a non-constant slot to emit `FREF` with `IRFL_TAB_NOMM`. =================================================================== -- Best regards, Sergey Kaplun