From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7847B5ED212; Tue, 5 Sep 2023 14:21:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7847B5ED212 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693912861; bh=VuFPsaQidTMP1RzsEF/aIVBPkeZBKPe08gIgMJ1yZGI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gyu1LLG5FaqD5dCu0BSCJZGnAkeJyvjvnt5dyEqg0SYtmFeIKa4XWgCRXwCTRz1R/ fMXW/Atm50rhYFb423xUO3TS/P/rkyiQOYPGwe3emyzHaDbMfmddcfJW9K65p8asIy Zyd+f/FA+Xe51d6muzMgnaAvxB+A8oFDc3U/+Rdg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B58045DC636 for ; Tue, 5 Sep 2023 14:21:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B58045DC636 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qdU79-00077L-R7; Tue, 05 Sep 2023 14:21:00 +0300 Date: Tue, 5 Sep 2023 14:16:16 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD342C4AF73C9E08B6B9ADEEA67E086309182A05F538085040AC6D158FAB6911544C0F5872310E37F14F2D2CD424365FBC05125E322ED0A613 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3295C83650092F9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D58C44ED3182E498638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8235D8403839AD2C736E23DE73BCC2D4A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC317C7E487E00003AA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0D75EB778CE7D8A0C68655334FD4449CB33AC447995A7AD1857739F23D657EF2BD5E8D9A59859A8B67ECBC18655D52CDF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53FA9704064CFF4A3A9F56326966F38C63F09C2D513307342F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C53592357E80577386EB3DB44FFC43F6AE520C013D8F12D6D8B105D063814F628EC43F9F5469178A1D7E09C32AA3244C2C24E081240D668D46498A40BCA20D19F94338140B71B8EE85A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3VBHtC3oXrNrJLhrMBoCrA== X-DA7885C5: 18206CB6BB6FD79F90997BBAA165129F3089334D4D3DCBCBB99E0EB8F2671926262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B08EAA670A964F650D88D5F90E99F092F0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 05.09.23, Maxim Kokryashkin wrote: > Hi, Sergey! > LGTM, except for the single nit regarding the commit message below. > > On Mon, Sep 04, 2023 at 06:50:26PM +0300, Sergey Kaplun wrote: > > This test may be flaky due to a non-monotonic filling of the vector with > I believe, that 'sparse' is a better fit here then 'non-monotonic'. It > is just a widely adopted term for vectors like this. Replaced with sparse, thanks! > -- Best regards, Sergey Kaplun