From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F3B6D4512A0; Sun, 3 Sep 2023 13:19:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F3B6D4512A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693736362; bh=AGn/hQ0QsnRM++qCEvnABBeQ3iAdOTU+aH0g3Gr7xk8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=B0Vpf2kssGo0uCHeqIjhL51IrIAa7XYxwjPvEPK/nimTISZYxi600Qe4/h9cOfycC 9VX1otEuPwHA1sUr/WBw4001pMBi9ASxxf4/xLKVuQiMDu/TdmlQVTC2Me44ukCYhj 7KkwYD6oZLyhtRgPgKjGJkSVYkgTa0o8h3AV4cGE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8BB434512A0 for ; Sun, 3 Sep 2023 13:19:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8BB434512A0 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qckCN-0007ef-Nx; Sun, 03 Sep 2023 13:19:20 +0300 Date: Sun, 3 Sep 2023 13:14:37 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD9A7859371734312374D1E4EA2190E575182A05F53808504037C962CF28AA70F42A6FE9CF57CD1E86577F131ACBDB9F490CA4ACAD140E8315 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF5628FE6781D09AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063795DC1BB912715AE68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EE29FAE0873C732274E1D1D5A677FD5A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3EA24FE487C076E5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C088D2E8BEBF93D4B068655334FD4449CB33AC447995A7AD18262FEC7FBD7D1F5BD5E8D9A59859A8B666D37212B2E9A769089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A584AD81C09CE00906BB50D2222A54C9EDB036E0296403D487F87CCE6106E1FC07E67D4AC08A07B9B01DAA61796BF5227BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF090918E37E885B3B04CC37976CB49634547075FBA4BEB7ABD67293F2F2D27B34C7C5EACBE3BE5B47CB50FCC00789692A90894B9B2D781D759C62BC5A0F855226A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBdR/qdXWEGOjYgAElz9CoA== X-DA7885C5: D491519F507BC4D11814AA068432E464F03816D4D2C358031C4B901E6060B9A1262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B2DED4971FD05393696FB341BEC76575F0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, with a minor nit below. On 28.08.23, Maxim Kokryashkin wrote: > This patch refactors symbol resolution in memprof, so > now they are resolved during the process of parsing. > This makes the generation mechanism excessive since > symtab updates are no longer affecting the previous events. > > Follows up tarantool/tarantool#8700 > --- > .../misclib-memprof-lapi.test.lua | 73 +++++-------------- > tools/memprof/humanize.lua | 16 ++-- > tools/memprof/parse.lua | 2 +- > tools/memprof/process.lua | 8 +- > 4 files changed, 31 insertions(+), 68 deletions(-) > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index 3cb5c8be..0eee4e21 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -86,44 +86,13 @@ local function form_source_line(line, source) > end > > local function form_trace_line(traceno, line, source) > - return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) > + return ("TRACE [%d] started at %s:%d"):format(traceno, source or SRC_PATH, line) Nit: Line width is more than 80 symbols. > end > > -local function fill_ev_type(events, symbols, event_type) > diff --git a/tools/memprof/humanize.lua b/tools/memprof/humanize.lua > index 267baa91..5b289ce3 100644 > --- a/tools/memprof/humanize.lua > +++ b/tools/memprof/humanize.lua > diff --git a/tools/memprof/parse.lua b/tools/memprof/parse.lua > index d865267b..1b6eceb4 100644 > --- a/tools/memprof/parse.lua > +++ b/tools/memprof/parse.lua > diff --git a/tools/memprof/process.lua b/tools/memprof/process.lua > index 0bcb965b..faf4be4e 100644 > --- a/tools/memprof/process.lua > +++ b/tools/memprof/process.lua > -- > 2.41.0 > -- Best regards, Sergey Kaplun