From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F0AAD4512A0; Sun, 3 Sep 2023 12:55:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F0AAD4512A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693734929; bh=r0YhTN1HDTIGmERfygk2kjoFKdQAXuxrPqca3VWg1WY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OC7Z+PI0umWdmUtGMmroNYc8BKkvMCBoca6EzlU05cFXE7uDL2Ct06bbpY4Z9C07E d5AyI3pSm5yPqcXunZOWv/L5JeZbprsl9nKFnqR8v1ucaNZ9pjIGEajq+m3AAXLSdL YLF2xwONEVMjVQpr1OoLX5ONMJpZoR9YTNjX0Hn8= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5FE8B4512A0 for ; Sun, 3 Sep 2023 12:55:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5FE8B4512A0 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qcjpG-0004QY-KE; Sun, 03 Sep 2023 12:55:27 +0300 Date: Sun, 3 Sep 2023 12:50:43 +0300 To: Maxim Kokryashkin Message-ID: References: <1b01124ea966b486d9462dea0d3653a45c4f81b1.1693481682.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b01124ea966b486d9462dea0d3653a45c4f81b1.1693481682.git.m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD9A7859371734312374D1E4EA2190E575182A05F5380850409CCDB272FEBC468B6DCDE1F2D5006AC4A309F847BE174694972DF706BDE80BAE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE4B4B08BC34B6C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BB77EBEDE93AEE1EC84EABD4D243AB98117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC7F89A93FC914C3A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0FE3A47D6FA29121068655334FD4449CB33AC447995A7AD18262FEC7FBD7D1F5BD5E8D9A59859A8B67A7B0CDC955A1711089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A50F924ED5094CD09DD8F94B4D4635A3CE69E0073C48B39ECBF87CCE6106E1FC07E67D4AC08A07B9B064E7220B7C550592CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEC74C6414C554BC77518AC2B64343E06261E64EB769513AA539738AEBC718AC120A397324AFDE1B8CB50FCC00789692AC23076CA1E06919A40CA9CFB62D53CA2A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBdR/qdXWEGMFdnbeWJ2taw== X-DA7885C5: 6381F7895A69E48BF7889BE27918173BBA4640BA4978BDE45FEE748433218332262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BCE443A9E0D0B6207980DC435E06EFBAD0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, with a single nit below. > +static int runtoolcmd(lua_State *L, const char *tool_name) > +{ > + lua_getglobal(L, "require"); > + lua_pushstring(L, tool_name); > + if (lua_pcall(L, 1, 1, 0)) { > + const char *msg = lua_tostring(L, -1); > + if (msg) { > + if (!strncmp(msg, "module ", 7)) > + msg = "unknown luaJIT command or tools not installed"; Nit: Use tab here for indentation. > + l_message(progname, msg); > + } > + return 1; > + } > + lua_getglobal(L, "arg"); > + return report(L, lua_pcall(L, 1, 1, 0)); > +} > + -- Best regards, Sergey Kaplun