From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BFE94608E87; Thu, 31 Aug 2023 18:37:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFE94608E87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693496243; bh=GqyXsKYPWiDXEFeWdpwprjs4FfVSg0cergO/swHHcSA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ttTEuAWPB3H4C6pr2TTIT6j9I8HN74VJSJVf4uqXIacwWh+Yi+pFYp4JW/CThwQ4p Z7vLHAkTETB41k/EUV+Vtp47Z/Z127G9uTG9xeHgIF8JgvyuVTQlrEUXTTQunoksNY uzYXdrRgRvViPFX7Ulx7TpeLPauSDpT8A70KeF3g= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1DFF9608E8F for ; Thu, 31 Aug 2023 18:36:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DFF9608E8F Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1qbjit-008h4w-0E; Thu, 31 Aug 2023 18:36:43 +0300 Date: Thu, 31 Aug 2023 15:19:19 +0000 To: Sergey Kaplun Message-ID: References: <20230824100233.25009-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230824100233.25009-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD90AAA51E9363FBE6A21DF977184D824F182A05F53808504064D10F2766D54A0C1A76C79FE9EDACC797E4B6CE78E01A6415E19297FCD721C3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770519A3AF4A224F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B5974C097743DA5CDDD5A28E7C39A421117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC7F48962964D238D0A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F790063757B1FBEA53BC6EDBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5A608708FF29AB5A2D77CDC4C33F31F5FBE61E0728494EF7BF87CCE6106E1FC07E67D4AC08A07B9B0B355ED1E20F5346ACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C786159FDC4342B01AB215F8BAC970E82697DE6657DA697DF4B9C129C7A497403ADF7FCD83EB73261D7E09C32AA3244CCAA130D03C1F93132227751603413B87F522A1CF68F4BE05BAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6jqRMsEo8wccH1ynnZmJhA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5318D99D21FB4EC489887AE109231EE2D81034A9278C83773402326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix binary number literal parsing. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 24.08.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Reported by Egor Skriptunoff. > > (cherry-picked from commit 377a8488b62a9f1b589bb68875dd1288aa70e76e) > > Binary number with fractional part is invalid. Parsing of such binary > numbers returns `STRSCAN_ERROR` for any numbers with non-zero fractional > part, because it gives non-zero power of the exponent (`ex2`) in > `strscan_bin()`. But binary numbers with a zero fractional part > considered as valid numbers. To avoid such inconsistency the check, that > the given base doesn't equal 2, is added, when parsing decimal point > part of the literal. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-binary-number-parsing > Issue: https://github.com/tarantool/tarantool/issues/8825 > ML: https://www.freelists.org/post/luajit/Fractional-binary-number-literals > Tarantool PR: https://github.com/tarantool/tarantool/pull/9028 > > Tarantool's CI is red, because static build on aarch64 can't fetch the > LuaJIT's submodule commit somehow. Looks unrelated to the commit:). > > src/lj_strscan.c | 1 + > .../fix-binary-number-parsing.test.lua | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 test/tarantool-tests/fix-binary-number-parsing.test.lua > > -- > 2.41.0 > -- Best regards, IM