From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 17761608E8F; Thu, 31 Aug 2023 18:36:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17761608E8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693496182; bh=M1gvB+smACoK+uYQqQLyOZUq1AA9xqWuya/kc1ZOuTs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GZNMDisP5kTq9KWs6K+IcUrc0fpzuX8nNfSpiYNsY410GqyMw4FRA8ncCqXv8/fyr TodxDF4NdxgHnlaO6FXtSIVdTZL1gMthnp0UKfE4NVDEdBYgAF5ROzn9soh/O7XIN8 wd2G7a2pOgYC9hBzPrnCKDUcaSYopRwfu2W2e+kw= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3FEE3608E87 for ; Thu, 31 Aug 2023 18:36:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3FEE3608E87 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1qbjiI-00GC06-0X; Thu, 31 Aug 2023 18:36:06 +0300 Date: Thu, 31 Aug 2023 15:18:42 +0000 To: Sergey Kaplun Message-ID: References: <20230815123215.510-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230815123215.510-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CD90AAA51E9363FBE6A21DF977184D824F182A05F53808504045F605B8A4769E3DB330800291D0671E779FCDCBABF6713845F7272D46362DA6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F907CB39E8CA2E228638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D55F081123B1C68C527E78E03C569C59117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2FD16FCC8DB5F8BEA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006371F24DFF1B2961425731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5A6BCC80C39542A6B7EC34DB049F1F134C82122E601244C1BF87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF80D8C93201EFFAE4CF5C7E5AAF1E4ACAA5E843CD4B65EC6226141811C1297774C6BFA615E6C3782A133B6A6C95330E12E4A85686BCAF8032FE3E8EED1D1D3863A74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6jqRMsEo8wd7NDLbrZDsuA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5318D99D21FB4EC4898C5DDC226B508ABD3D8F8631D9BF961852326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_VARG, part 3. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 15.08.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Thanks to Peter Cawley. > > (cherry-picked from commit abb27c7771947e082c9d919d184ad5f5f03e2e32) > > In case, when `BC_VARG` set the VARG slot to the non-top stack slot, > `maxslot` value was unconditionally set to the destination slot, so some > top slots may be omitted in the snapshot entry. Since these slots are > omitted, they are not restored correctly, when restoring from snapshot > for this side exit. > > This patch adds the check for the aforementioned case, to avoid maxslot > shrinking. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1046-fix-bc-varg-recording > PR: https://github.com/tarantool/tarantool/pull/8986 > Related issues: > * https://github.com/LuaJIT/LuaJIT/issues/1046 > * https://github.com/tarantool/tarantool/issues/8825 > > src/lj_record.c | 12 +++- > .../lj-1046-fix-bc-varg-recording.test.lua | 58 +++++++++++++++++++ > 2 files changed, 67 insertions(+), 3 deletions(-) > create mode 100644 test/tarantool-tests/lj-1046-fix-bc-varg-recording.test.lua > > -- > 2.41.0 > -- Best regards, IM