From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 946555C1DB2; Mon, 28 Aug 2023 17:09:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 946555C1DB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693231745; bh=biD3r47YbCp0uI2zBT5lgfclUVtkPuFjSY5NGU8OwvI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HFmI2OMNhXVoLzSEPs8gH8JWrNvESHcbaK3cPiRMQgitONt0iBP0HOeS6d4548aC2 9PsyXWxeOLNHZWMiJXuwV/N7a/q61NN2R1ASFAS4NfsruJIvrQrkAPFYEBLz0mWefp cA+oD6wyH3ca/CvBjuLvRJHTrzvlctjpM7AZqlpI= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 697175BE742 for ; Mon, 28 Aug 2023 17:09:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 697175BE742 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1qacvP-0067Ei-0B; Mon, 28 Aug 2023 17:09:03 +0300 Date: Mon, 28 Aug 2023 17:04:18 +0300 To: Sergey Bronnikov Message-ID: References: <20230825150024.23247-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9954329A9C7AF96E9E2DDB7AE4AB0A4FB6A2275B35D8A45EC182A05F538085040492ACE9AF4D3C65065589EBAEAE87C062690F2E391F07766A8446CF5AAC7B185 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A548C5E803E75135EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637603D0B7FC8E46DFC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D79734358C5BEEBA075BEC9F4CE3D26A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC4F326BE173F0FED1A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD2D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3A0CC8883A33FD9CD35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C37F1C4A83D23B8DEB786FEA854EEF1A891F63FD86D96750F87CCE6106E1FC07E67D4AC08A07B9B08ED1AC82D843A2BBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340FE9920E7E3E5C629FCFFE47A074A435A7E138B01CD89DE8E3C2CBAED876D1EED6EF48DC196354FA1D7E09C32AA3244C5F3D60F3D029EE62CC4B21554124424B795D98D676DD64D085A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC6BcuK2ROzNfoprXC7VgA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76943E64135E244AAB165589EBAEAE87C0684876E3DC5E244DFDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_TSETM. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 28.08.23, Sergey Bronnikov wrote: > Hi, Sergey > > > thanks for the patch! LGTM > > See a minor comment inline. > > > Sincerely yours, > > Sergey > > > On 8/25/23 18:00, Sergey Kaplun wrote: > > From: Mike Pall > > > > Analyzed by Sergey Kaplun. > > > > I've discovered that bug is not reproduced when LUAJIT_ENABLE_TABLE_BUMP > is enabled, by default it is disabled. > > CFLAGS="-DLUAJIT_ENABLE_TABLE_BUMP" cmake -S . -B build > -DCMAKE_BUILD_TYPE=Debug > > cmake --build build --parallel > > It is probably worth to mention in commit message. Feel free to ignore. I suppose, since it's not enabled by default it's better to ignore it. It's hidden due-to DCE optimizations, most probably. Ignoring. > > > > > -- Best regards, Sergey Kaplun