From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C5E525C4552; Mon, 28 Aug 2023 18:25:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C5E525C4552 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693236314; bh=dtBgJprbSrK55Rp4qv2TccosVMUVXb+9Up1palaO9kE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tOFm8YVCGgpyJ/Y6GTvQBaoUna8uBrxmo55PpTL8BSgmzbuVjudhpImjhxedaMjxe HHrh7+LxglyLM4kSMSAGnSQpknPzsISUJ9yQYwLfkfs+NgtRU+0B12HXVKLqQFydNh F99rvCU4T5VLQLXLZoQk8R5/lZ6c4Ex8ykIgSC2Y= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64F045C4556 for ; Mon, 28 Aug 2023 18:23:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64F045C4556 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1qae5l-005H2x-1G; Mon, 28 Aug 2023 18:23:49 +0300 Date: Mon, 28 Aug 2023 18:19:04 +0300 To: Maxim Kokryashkin Message-ID: References: <20230825150024.23247-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9954329A9C7AF96E95E2F5ED1E806A3C3476BCD21812BC244182A05F5380850404B5E6D610C45D44A55668374864F4890D27BBC0958E2754D587A76E76590A5FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7466896EF24E80F12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B0052F7941B60F658638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D856768B5EE17A43AA4E166D3EAA62A5D3117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCCFF48519C1EE79E1A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7A2AE38A8E97BAFFB1D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE313BDA61BF53F5E1DBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE75B51C8FB0C3E748C731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A59B0F99835AA2A73DE1B5488B73CF122D0C883B46308A393FF87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF90E9B4210F766A0D30A7A2A139F7ACEE0BB02AF416F03F938C7EFF2ADD97BDDC711F655CCE117FA35088795BE9012648E348468551AD3AAA8C8E3D3BD3BE948DE48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC6BcuK2ROx8S7phIJVlQg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769E80B8A98A24D082155668374864F48905AB84C5967107110DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_TSETM. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the comments! Fixed your comments inline. On 28.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the fixes! > LGTM, except for a few more comments below. > On Mon, Aug 28, 2023 at 06:02:12PM +0300, Sergey Kaplun wrote: > > > > + > > > > +local TEST_VALUE = '5' > > > > +local TEST_IDX = 5 > > > > + > > > > +local function slot5() > > > > + return nil, nil, nil, nil, TEST_VALUE > > > > +end > > > Why the fifth slot? Drop a comment. > > > > Fixed. See the iterative patch below. > > > > > > =================================================================== > > diff --git a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua > > index 7ae0a99d..74625a79 100644 > > --- a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua > > +++ b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua > > @@ -15,6 +15,8 @@ local jit_dump = require('jit.dump') > > local TEST_VALUE = '5' > > local TEST_IDX = 5 > > > > +-- XXX: Use big enough slot numbewr to be overwritten by VM event > Typo: s/Use/Use a/ > Typo: s/numbewr/number/ > Typo: s/by VM/by the VM/ > > +-- handler function. > Please also add that this is an empirical number. Fixed, thanks. =================================================================== diff --git a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua index 74625a79..0e82c0b9 100644 --- a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua +++ b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua @@ -15,8 +15,8 @@ local jit_dump = require('jit.dump') local TEST_VALUE = '5' local TEST_IDX = 5 --- XXX: Use big enough slot numbewr to be overwritten by VM event --- handler function. +-- XXX: Use a big enough slot number to be overwritten by the VM +-- event handler function. This value is empirical. local function slot5() return nil, nil, nil, nil, TEST_VALUE end =================================================================== -- Best regards, Sergey Kaplun