From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BF19159568B; Mon, 21 Aug 2023 16:21:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF19159568B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692624099; bh=K3vz32Op70NHqvYdh5ErIhXxa55gCC+JOQ/Ozp5dmqM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Uw/qi96AKA9/hcr8FH2AwRCRVHz3xCSFPVvstYmGzhWNQA6KGJxRnmusfub/Efh1A Sv2XcnrF/YTCDz5/0brS0eaGaWkdNc7op/WSv1xZJLJRyf2hudSVM54KHPXY+sh7N8 WErQg4tCYxkdyslQemMUGifA6ANFFGscAbbbrC4k= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DA6DD59568B for ; Mon, 21 Aug 2023 16:21:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DA6DD59568B Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1qY4qd-00FNJP-2B; Mon, 21 Aug 2023 16:21:36 +0300 Date: Mon, 21 Aug 2023 13:05:41 +0000 To: Maksim Kokryashkin Message-ID: References: <20230821100604.61363-1-max.kokryashkin@gmail.com> <20230821100604.61363-4-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230821100604.61363-4-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93C8852532D76B9E3B62DC7F09619FD73B4ABEF74D25B7E0A182A05F538085040CA6EBBDC64F6D34B8856F2A8980A6B5F822D2BCEF511A8CA74357FB13BC037D2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72C932D6B54DFB189EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637829D9538242026C38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87F1D69D6CF593F085A706B4BB2797806117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2076EC165927BBF1389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC87AE820D2C17D0E56F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE70BB89B22BF4660DC731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5FF639B7E4F988C42F8A77A8B40244691E59739D49F5063FFF87CCE6106E1FC07E67D4AC08A07B9B062B3BD3CC35DA588CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3474B2583E51315984EAB6BD3CEFD12054909A7A48E6F444152BB6700CDBAEB7CDAE3235F11BE01B451D7E09C32AA3244CFC016073B9F3F4CD3A8A418DF3E19984795D98D676DD64D0ED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHJI2DMjVra1tIt7XLJPCtA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531A1AE1FF5939ED19C0C321A9793F03A02AF91F2C3853A33E92326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 3/3] sysprof: improve parser's memory footprint X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, except several nits below. On 21.08.23, Maksim Kokryashkin wrote: > From: Maxim Kokryashkin > > This patch reduces sysprof's parser memory footprint, > by avoiding reading all callchains before collapsing them. > Instead of it, parser merges stacks immediately after > reading them atnd stores counts in a lua table. Typo: s/atnd/and/. Typo: s/lua/Lua/. > > The `collapse.lua` module is purged as a result of the > patch, but it is left as a stub to keep the integrational > testing intact. This stub should be removed in the next > series. > > Resolves tarantool/tarantool#8700 > --- > Note: the assertion, proposed by Igor wasn't added, since it breaks > integrational testing. OK, anyway, thanks for trying. > > tools/CMakeLists.txt | 4 ++ > tools/sysprof.lua | 21 +------ > tools/sysprof/collapse.lua | 123 +----------------------------------- > tools/sysprof/parse.lua | 125 ++++++++++++++++++++++++++----------- > 4 files changed, 100 insertions(+), 173 deletions(-) > diff --git a/tools/sysprof/parse.lua b/tools/sysprof/parse.lua > index 5b52f104..92e475a6 100755 > --- a/tools/sysprof/parse.lua > +++ b/tools/sysprof/parse.lua > @@ -143,18 +153,63 @@ local function parse_symtab(reader, symbols, vmstate) > +local function insert_lua_callchain(chain, lua) > + local ins_cnt = 0 > + local name_lua > + for _, fr in ipairs(lua.callchain) do > + ins_cnt = ins_cnt + 1 > + if fr.type == FRAME.CFUNC then > + -- C function encountered, the next chunk > + -- of frames is located on the C stack. > + break > + end > + name_lua = fr.name > + > + if fr.type == FRAME.LFUNC > + and lua.trace.traceno ~= nil > + and lua.trace.addr == fr.addr > + and lua.trace.line == fr.line > + then > + name_lua = lua.trace.name Still misindented operator. > + end > + > + table.insert(chain, name_lua) > + end > + table.remove(lua.callchain, ins_cnt) > +end > + > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM