From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DF3D0595D96; Mon, 21 Aug 2023 14:22:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF3D0595D96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692616932; bh=sQ09akqT32fw9OfKEsFgtMpX3W4dtXgEezvxJPINesA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=B/QaQrastnmc9x1yB6MM9Nrk0eCMN9NJjXq8e0TwvetiobNQgQXt83HkGeuCoVu+Z HP1W2RRKqmSJSHBXRkORhkeryRwcp+i3w8MDE/uy94/bYfzQoE0lV7lpdpxp2EZ2hC 3gNtE0atkmrebFX6uEzZMi02b9WZNOn4EKZoLdJI= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8FEB659568B for ; Mon, 21 Aug 2023 14:21:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FEB659568B Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1qY2yj-0078Rf-0f; Mon, 21 Aug 2023 14:21:49 +0300 Date: Mon, 21 Aug 2023 11:05:56 +0000 To: Maxim Kokryashkin , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93C8852532D76B9E3155AD137556C14E709A4466288DB511C182A05F538085040076E8CFE217185778920057E3945D309C48C033C1ABCF0DD6BF0881856EF198A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637174E2957C4CE0F938638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8334DDFF6EE7E7ECE6DB2057CE61EB306117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCD215BE4436AF2686A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637FB177F6A8366F17BEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5762A63A2CB18D4EF07DC18963EB97AD5F53627F27C6F9E9FF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34524B2D44961BF9C667DC1ADA56150505C78D4A5787B9F2F7B194A37196532E7C30B07CEAFE94C7CF1D7E09C32AA3244C2F6D2EF604AE6809914AA36D50F7C2761DD47778AE04E04DBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHJI2DMjVra3Go3HsMh13Lg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531D70200A3CDCA3A98F20F5076551437D00AAE1B72BB4108BC2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Pals, thanks for your reviews! I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 03.08.23, Igor Munkin wrote: > This series implements flak8 linter support for existing Python scripts > in the repo (i.e. luajit-gdb.py and luajit_lldb.py). Almost all patches > simply fix PEP8 violations found in our code, and the last patch of the > series adds flake8 config, CMake subtarget to run flake8 in scope of the > new target and adjusts lint workflow respectively. > > To be honest, not all of the errors reported by flake8 (or rather > pycodestyle that is wrapped by flake8) are fixed at the moment. One can > find some TODO entries in .flake8rc, since I've failed making flake8 > happy and have finally given up. If you have any ideas how to resolve > these TODOs, you're very welcome. > > Branch: https://github.com/tarantool/luajit/commits/imun/add-flake8 > > Igor Munkin (15): > test: fix E122 errors by pycodestyle > test: fix E128 errors by pycodestyle > test: fix E201 and E202 errors by pycodestyle > test: fix E203 errors by pycodestyle > test: fix E231 errors by pycodestyle > test: fix E251 errors by pycodestyle > test: fix E301 errors by pycodestyle > test: fix E302 errors by pycodestyle > test: fix E303 errors by pycodestyle > test: fix E305 errors by pycodestyle > test: fix E502 errors by pycodestyle > test: fix E711 errors by pycodestyle > test: fix E722 errors by pycodestyle > test: fix E741 errors by pycodestyle > test: run flake8 static analysis via CMake > > .flake8rc | 12 ++ > .github/workflows/lint.yml | 4 +- > src/luajit-gdb.py | 325 ++++++++++++++++++++++------------- > src/luajit_lldb.py | 336 +++++++++++++++++++++++-------------- > test/CMakeLists.txt | 28 ++++ > 5 files changed, 458 insertions(+), 247 deletions(-) > create mode 100644 .flake8rc > > -- > 2.30.2 > -- Best regards, IM