From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10EA3572182; Mon, 21 Aug 2023 11:12:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10EA3572182 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692605529; bh=GPc+j+63qag7fyFODLDAn2/NpBqr1xJ1XRKSpHNn/0M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VeLMZHfpVHsSRiBBpb7UsF6TppnswtgqADJwYpzSz+L7vshvRb+f2MdorqwqxcDNm J1ECHpFlwiouSS7wGjTDdxSPbC82Tt3a0zKSeJvsInf0JV42TcjPIlj878Og4BGlHc X0Mqddc4HKBftRXwcjO74cZdYohdxatgSEfeP0rw= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9E752572182 for ; Mon, 21 Aug 2023 11:12:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9E752572182 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1qY018-00Cllo-1G; Mon, 21 Aug 2023 11:12:06 +0300 Date: Mon, 21 Aug 2023 11:07:21 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD90D1D1AB54508998164C3387BA0FA5B81EA24825B1EA10A89182A05F5380850404C228DA9ACA6FE27C3D0CF5D892CB233B15A6C9643067FF979331291E136A105AA7265F92D1D627E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7257031E595304076EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B2BC59D094D41B978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80D3897A7AE39DBFB6DCBB2DD4C02A950117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC30B6221521ACED37A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD28765F5520A300B2D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88302FCEF25BFAB345C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7FCEEFFE83360B3FE2DBA43225CD8A89F890A246B268E114E57739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5949570E7A71085B014BBD60DE71C75F30C883B46308A393FF87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3441661D6226BE8C31A2F603533FCF8A8B410893F912A7E213CE770712472CFEE5F63BDBC13ECF5C981D7E09C32AA3244CEE146390A77ADBDE85FD5378475B814430363D8B7DA7DD4485A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHJI2DMjVra3wGJOOZrlRKw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76973BE0E6FA90AB24AB15A6C9643067FF95AB84C5967107110DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] Fix pow() optimization inconsistencies. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments inline. On 18.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > > thanks for the patch! LGTM with two minor comments inline. > > > On 8/15/23 12:36, Sergey Kaplun wrote: > > From: Mike Pall > > > > (cherry-picked from commit 9512d5c1aced61e13e7be2d3208ec7ae3516b458) > > > > This patch fixes different misbehaviour between JIT-compiled code and > misbehaviour -> misbehaviours Fixed. > > the interpreter for power operator with the following ways: > > * Drop folding optimizations for base ^ 0.5 => sqrt(base), as far as > > pow(base, 0.5) isn't interchangeable and depends on the > > implementation. > > * Drop folding optimizations for 2 ^ int_pow => ldexp(1.0, int_pow), to > > avoid dependcy on the implementation. > dependcy -> dependency Fixed. > > * Now `asm_pow()` always assemble a call to the `lj_vm_powi()` function, -- Best regards, Sergey Kaplun